sas requested changes to this revision.
sas added a comment.
This revision now requires changes to proceed.

I think it would be cleaner/smaller if you didn't use pure-virtual functions, 
but instead you had `CanReseume()` return `false` in `Process.h`, and had a 
default implementation of `DoResume()`  that called 
`llvm::report_fatal_error()`.

Instead, here, you're defaulting `CanResume()` to `true` and forcing every 
child class to redefine as `false` and provide an error'ing implementation of 
`DoResume()`.


https://reviews.llvm.org/D37651



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to