jingham requested changes to this revision.
jingham added a comment.

This seems like an awkward solution to me.  Having CanResume and DoResume seems 
like it over-determines the problem.

Why wasn't it enough for DoResume to fail and the error to be propagated?

I'm also uncomfortable that this is making a possible code path for some 
programmer error to cause a fatal error in lldb (which we really want never to 
happen).  It would be much better to rely on the failure of DoResume.


https://reviews.llvm.org/D37651



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to