jingham added a comment.

But whatever the solution, you should never use llvm::report_fatal_error.  It's 
fine to put in an lldb_assert which will assert when the error is hit in the 
test suite, but not in released lldb's.  After all, the worst that will happen 
if somebody working on lldb were to leave in a code path that called DoResume 
without CanResume is that the state of that core file target would be wrong.  
That is not an error worth taking down whoever happened to load the lldb 
framework into their program, or destroying all the other debug sessions or 
targets active in lldb.


https://reviews.llvm.org/D37651



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to