davide added inline comments.
================ Comment at: source/Target/Target.cpp:3949 + idx); + assert(option_value); + return option_value->GetCurrentValue(); ---------------- aprantl wrote: > davide wrote: > > add an assertion message if you don't mind? > This code is mechanically duplicated from the other functions in this file, > and I was actually planning on making another pass that auto-generates all of > the properties and the accessor functions from a .inc file using an > llvm-style HANDLE_foo() macro. Sure, even better :) It would be awesome if lldb didn't do its own command line handling but would use something like `cl::opt`, but I guess that's a battle for another day. https://reviews.llvm.org/D43099 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
