Hi, Orcan! Just pushed changes to master. I also made some modifications to song.cpp code and replaced wrong calls to printf() with std::cout and friends to make it look more c++'able.
Thanks! Regards, Andrew 07.01.2015 10:23, Orcan Ogetbil wrote: > On 7 January 2015 at 00:07, Andrew Deryabin wrote: >> 07.01.2015 08:17, Orcan Ogetbil пишет: >> >>> On 6 January 2015 at 16:14, Andrew Deryabin wrote: >>>> Great!! >>>> >>>> Now it's time to port MusE to Qt 5 ;) >>>> >>> Wow! Great work guys. I always wanted to write the LV2 plugin, but >>> never had time. >>> Thank you Andrew for taking care of this. >>> >>> Porting Qt? Good memories. :) >>> I read that that will be easier than last time. >> >> Well, If nothing serious will happen with my free time, I'll try cope with >> this task till May or April (of this year) :) >> > Awesome! I just had a chance to try the lv2 stuff. It works like a > charm. I cannot thank you enough for this!!! > > Note that, though, I got some compilation errors with > -Werror=format-security, such as > > song.cpp: In function 'void MusECore::writeStringToFile(FILE*, char*)': > song.cpp:3207:23: error: format not a string literal and no format > arguments [-Werror=format-security] > printf(writeString); > ^ > I made a fix/workaround for this. This compilation flag is enabled by > default in various distros (at least in Fedora and Ubuntu) during > package building. Packagers will likely want to have this fix. > I added the flag to the compilation flags CMAKE_CXX_FLAGS, so that we > will see such errors earlier in the game next time. Sorry, I should > have done this earlier. > > Apparently I cannot commit to git anymore. It's been a while since > last time. I am attaching the patch. Could someone commit this in for > me? > > Also you will most likely need to do a clean rebuild on your checkout > after this. > > Cheers, > Orcan ------------------------------------------------------------------------------ Dive into the World of Parallel Programming! The Go Parallel Website, sponsored by Intel and developed in partnership with Slashdot Media, is your hub for all things parallel software development, from weekly thought leadership blogs to news, videos, case studies, tutorials and more. Take a look and join the conversation now. http://goparallel.sourceforge.net _______________________________________________ Lmuse-developer mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/lmuse-developer
