On 15 April 2015 at 11:02, Ola Liljedahl <[email protected]> wrote:
> On 15 April 2015 at 16:57, Mike Holmes <[email protected]> wrote: > >> >> >> On 15 April 2015 at 04:08, Taras Kondratiuk <[email protected]> >> wrote: >> >>> On 04/15/2015 05:29 AM, Mike Holmes wrote: >>> >>>> >>>> >>>> On 14 April 2015 at 16:21, Maxim Uvarov <[email protected] >>>> <mailto:[email protected]>> wrote: >>>> >>>> On 04/14/15 22:59, Mike Holmes wrote: >>>> >>>> The shm test is obsolte, remove it >>>> >>>> Why is it obsolete? >>>> >>>> >>>> A few reasons >>>> >>>> It is never called and hence it is not maintained and it core dumps, I >>>> dont know how many releases that has been true but it is now, but >>>> fundamentally it is nowhere near as comprehensive a test as we have in >>>> validation and so it is no longer necessary. >>>> >>>> Additionally we need to move or delete everything in api_test becasue >>>> that whole directory is obsolete. The only thing I plan to save is the >>>> ring test which needs to migrate to validation and or the performance >>>> test unless we transition the ring code inside Linux-generic as >>>> suggested today. >>>> >>> >>> Our validation tests should validate only ODP API. >>> Rings don't belong to API. >>> >> Why do we even have the ring implementation when ODP has polled queues > which have the same semantics? > Is there some use case which requires the user to know the implementation > of the queues (e.g. for placing the memory used by the rings in some > specific (shared) place)? > I dont recall the motivation now, but without a case to keep them it looks like no one needs the ring code, we are certainly not testing it in any way. If it stays I want it tested or it will rot like odp_shm has in this very directory. To test it that probably means that helpers are independently tested from the API so we need to find the correct location for the test - maybe helpers need to be an independent library to start with ? > > > >> >> That is also part of the current discussion about what helpers are. >> I hope to work towards resolving that, helpers are currently not part of >> the official API, they are helpers, but we have helpers that are heavily >> used - eth.h etc and those like ring that are not used at all. >> >> >> -- >> Mike Holmes >> Technical Manager - Linaro Networking Group >> Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs >> >> >> >> _______________________________________________ >> lng-odp mailing list >> [email protected] >> https://lists.linaro.org/mailman/listinfo/lng-odp >> >> > -- Mike Holmes Technical Manager - Linaro Networking Group Linaro.org <http://www.linaro.org/> *│ *Open source software for ARM SoCs
_______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
