> -----Original Message----- > From: ext Benoît Ganne [mailto:[email protected]] > Sent: Thursday, April 16, 2015 1:51 PM > To: Savolainen, Petri (Nokia - FI/Espoo); Taras Kondratiuk > Cc: lng-odp > Subject: Re: [lng-odp] [PATCH] api_test: remove odp_shm_test > > >> I think there is a grey area here: we say helpers are not part of ODP, > >> but we cannot compile ODP tests and examples w/o them. Can we really > >> consider an implementation to be ODP-compliant w/o those? > > > An implementation does not have to (should not) re-implement the > > odp/helper directory. It can be delivered as is (similar to odp/test > > or odp/example). Helpers can be thought as part of the test suite > > infrastructure, but pulled to the top level as definitions are > > generic enough. > > For example, tests and examples make heavy use of odph_linux_pthread_* . > This is a problem for eg. bare metal environment. I believe that Phil > proposed during the call to rename that "execution_unit" or something > similar exactly for this reason. > But then we also have the problem with odph_linux_process_*, especially > for our platform where we could have different images for different > process: some for Linux, some for bare metal. Bare metal images cannot > run under Linux and vice-versa. > If helpers are needed for examples and tests, I would argue they should > be as platform-neutral as possible and carefully defined. This is not a > problem for protocols headers, but it is for processes management. > > ben
Some tests/examples (e.g. Ipsec) include also Linux/posix headers directly (so bare metal problems are not limited to odph_linux_*). And that's OK - we don't want ODP to become another OS. The software written under the ODP project may not be able support different bare metal targets, but leave that (validation) effort to individual vendors. In practice, test suite/examples depend on Linux now, and that may be the case in the future also (as conclusion of this discussion). The important thing is that the API does not depend on Linux/POSIX/etc - only on C99. -Petri _______________________________________________ lng-odp mailing list [email protected] https://lists.linaro.org/mailman/listinfo/lng-odp
