On 1 June 2017 at 02:22, Dmitry Eremin-Solenikov <[email protected]> wrote: > On 31.05.2017 21:03, Honnappa Nagarahalli wrote: >> On 31 May 2017 at 03:02, Savolainen, Petri (Nokia - FI/Espoo) >> <[email protected]> wrote: >>> >>> >>> Arch specific code is not commonly added into odp-linux, but when you do >>> add it you need to try hard not to break the code for others. You can test >>> the C generic also on ARM/x86, before turning the asm optimized version the >>> default. So, also without a PPC target you can develop/test the C generic >>> path (on ARM/x86) and build it for PPC to check that makefiles and #ifdefs >>> are OK. >> >> This is how the scope of the work increases unnecessarily. As we had >> agreed during our discussions, functions for MIPS and PowerPC code >> should be provided by the respective maintainers. It is not possible >> to compile for 8 different targets ourselves. >> >> ODP does not run the CI for these 2 targets. >> >> Why not fold these two targets into default? > > Exactly. Do you provide default target non-specific implementation?
The 'default' directory in arch directory cannot be compiled. The code under x86 is generic enough and is non-target specific implementation. > > -- > With best wishes > Dmitry
