> -----Original Message-----
> From: Honnappa Nagarahalli [mailto:[email protected]]
> Sent: Saturday, June 03, 2017 7:23 AM
> To: Savolainen, Petri (Nokia - FI/Espoo) <[email protected]>
> Cc: Brian Brooks <[email protected]>; [email protected]; Ola
> Liljedahl <[email protected]>
> Subject: Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files
>
> On 1 June 2017 at 02:43, Savolainen, Petri (Nokia - FI/Espoo)
> <[email protected]> wrote:
> >
> >
> >> -----Original Message-----
> >> From: Honnappa Nagarahalli [mailto:[email protected]]
> >> Sent: Wednesday, May 31, 2017 9:03 PM
> >> To: Savolainen, Petri (Nokia - FI/Espoo) <[email protected]>
> >> Cc: Brian Brooks <[email protected]>; [email protected]; Ola
> >> Liljedahl <[email protected]>
> >> Subject: Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files
> >>
> >> On 31 May 2017 at 03:02, Savolainen, Petri (Nokia - FI/Espoo)
> >> <[email protected]> wrote:
> >> >
> >> >
> >> >> -----Original Message-----
> >> >> From: Honnappa Nagarahalli [mailto:[email protected]]
> >> >> Sent: Wednesday, May 31, 2017 6:11 AM
> >> >> To: Savolainen, Petri (Nokia - FI/Espoo)
> <[email protected]>
> >> >> Cc: Brian Brooks <[email protected]>; [email protected];
> Ola
> >> >> Liljedahl <[email protected]>
> >> >> Subject: Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files
> >> >>
> >> >> On 24 May 2017 at 06:55, Savolainen, Petri (Nokia - FI/Espoo)
> >> >> <[email protected]> wrote:
> >> >> >
> >> >> >
> >> >> >> -----Original Message-----
> >> >> >> From: Honnappa Nagarahalli
> [mailto:[email protected]]
> >> >> >> Sent: Wednesday, May 24, 2017 6:59 AM
> >> >> >> To: Savolainen, Petri (Nokia - FI/Espoo)
> >> <[email protected]>
> >> >> >> Cc: Brian Brooks <[email protected]>; lng-
> [email protected];
> >> Ola
> >> >> >> Liljedahl <[email protected]>
> >> >> >> Subject: Re: [lng-odp] [API-NEXT PATCH v6 3/6] Add arch/ files
> >> >> >>
> >> >> >> On 23 May 2017 at 02:10, Savolainen, Petri (Nokia - FI/Espoo)
> >> >> >> <[email protected]> wrote:
> >> >> >> >> diff --git a/platform/linux-generic/arch/powerpc/odp_cpu.h
> >> >> >> >> b/platform/linux-generic/arch/powerpc/odp_cpu.h
> >> >> >> >> new file mode 100644
> >> >> >> >> index 00000000..e118e709
> >> >> >> >> --- /dev/null
> >> >> >> >> +++ b/platform/linux-generic/arch/powerpc/odp_cpu.h
> >> >> >> >> @@ -0,0 +1,10 @@
> >> >> >> >> +/* Copyright (c) 2017, Linaro Limited
> >> >> >> >> + * All rights reserved.
> >> >> >> >> + *
> >> >> >> >> + * SPDX-License-Identifier: BSD-3-Clause
> >> >> >> >> + */
> >> >> >> >> +
> >> >> >> >> +#ifndef ODP_POWERPC_CPU_H_
> >> >> >> >> +#define ODP_POWERPC_CPU_H_
> >> >> >> >> +
> >> >> >> >> +#endif
> >> >> >> >
> >> >> >> >
> >> >> >> > Does this patch break build for all other archs but arm and
> x86?
> >> >> >> Shouldn't you do the same (dummy) definitions for all
> architectures,
> >> as
> >> >> >> you do for x86?
> >> >> >> >
> >> >> >> > Odp-linux should be usable in any system that runs Linux. It's
> not
> >> >> >> practical to test on every arch, but we should always offer the
> >> default
> >> >> >> code path that builds and should work fine on any arch. For
> example,
> >> I
> >> >> did
> >> >> >> cross compile my latest x86 specific changes for PowerPC to see
> that
> >> a
> >> >> >> non-x86 path also builds.
> >> >> >> >
> >> >> >>
> >> >> >> We do not have the environment to compile for PowerPC or MIPS.
> Even
> >> if
> >> >> >> we write dummy functions, we will not be able to compile the code
> >> for
> >> >> >> those targets. During our earlier discussions, there was an
> >> agreement
> >> >> >> that we will not do this for PowerPC or MIPS. Respective arch
> owners
> >> >> >> have to create those functions.
> >> >> >
> >> >> > ODP dependencies file have some instructions for cross compiling.
> >> With
> >> >> Ubuntu you just need to install some extra packages. E.g.
> >> >> >
> >> >> > sudo apt-get install gcc-powerpc-linux-gnu
> >> >> >
> >> >> > So, you have the environment to build for e.g. PowerPC. Since odp-
> >> linux
> >> >> is for everybody (not only x86 and arm), you must not break the
> build
> >> for
> >> >> others. You may offer the minimal support, dummy functions,
> something
> >> that
> >> >> is functionally correct but not optimized - but you must not break
> the
> >> >> build.
> >> >> >
> >> >>
> >> >> Why would we have code which is not tested? Successful compilation
> >> >> does not mean, the code would work. It is better that compilation
> >> >> fails rather than things not work during run time.
> >> >>
> >> >> Does ODP claim it supports PowerPC? As far as I know, it claims it
> is
> >> >> supported on Linux. In that case, why not use the 'default' in arch
> >> >> directory for PowerPC?
> >> >>
> >> >> What about MIPS?
> >> >>
> >> >> What about Kalray?
> >> >>
> >> >> What is the version of the gcc compiler that needs to be used?
> >> >>
> >> >> What about support for Clang on PowerPC and MIPS? What is the Clang
> >> >> version we need to support?
> >> >>
> >> >> These builds are in ODP CI.
> >> >>
> >> >> We had agreed that support for PowerPC and MIPS needs to come from
> >> >> respective owners.
> >> >
> >> >
> >> > Odp-linux should build and run where ever you have Linux. Obviously,
> we
> >> cannot guarantee the quality without testing, but we must not
> deliberately
> >> break the build. After every commit, makefiles rules and potential arch
> >> files/functions must be present to build for MIPS/PPC/Kalray etc. You
> >> don't need to write assembly for other than ARM, but you need to add
> >> stubs/generic C implementations for others.
> >>
> >> Again, what is the use of code that compiles but not tested and does
> >> not work potentially?
> >
> >
> > Think it this way, the asm/arch-specific code is an exception. In order
> to get that exception path approved, you need to provide the default C-
> only code path. You should develop and test the default path also locally
> before adding the asm path. You can do it in two commits. First commit,
> implement only the default path and test it on your favorite system (x86,
> arm, ...). Second commit, implement and enable asm path for your favorite
> target. This way both paths go through our CI.
> >
> This does not help in solving the problem we are facing today,
> compiling for 8 different targets.
>
> > True, we should force default path testing in our CI. Anyway, lack of a
> CI target today is not valid reason to break build for others. While
> adding arch specific code, you need do everything you can *not* to break
> build or functionality for others.
>
> Just curious, did you compile the code for PPC and MIPS or are you
> saying because you did not find the code under these target specific
> directories?
>
I suspect that this kind of definition breaks build for other archs than
arm/x86. First you add dependency to arch/@ARCH_DIR@/odp_cpu.h file, but those
files are empty for ppc/mips/default. The same dummies you have for x86 should
be added to other targets. Do you say that it builds ?
-Petri
diff --git a/platform/linux-generic/Makefile.am
b/platform/linux-generic/Makefile.am
index 79f0e70c..6ecafbb8 100644
--- a/platform/linux-generic/Makefile.am
+++ b/platform/linux-generic/Makefile.am
@@ -8,6 +8,7 @@ AM_CFLAGS += -I$(srcdir)/include
AM_CFLAGS += -I$(top_srcdir)/include
AM_CFLAGS += -I$(top_srcdir)/include/odp/arch/@ARCH_ABI@
AM_CFLAGS += -I$(top_builddir)/include
+AM_CFLAGS += -I$(top_srcdir)/arch/@ARCH_DIR@
AM_CFLAGS += -Iinclude
AM_CFLAGS += -DSYSCONFDIR=\"@sysconfdir@\"
AM_CFLAGS += -D_ODP_PKTIO_IPC
@@ -182,6 +183,7 @@ noinst_HEADERS = \
${srcdir}/include/protocols/ipsec.h \
${srcdir}/include/protocols/tcp.h \
${srcdir}/include/protocols/udp.h \
+ ${srcdir}/arch/@ARCH_DIR@/odp_cpu.h \
${srcdir}/Makefile.inc
diff --git a/platform/linux-generic/arch/powerpc/odp_cpu.h
b/platform/linux-generic/arch/powerpc/odp_cpu.h
new file mode 100644
index 00000000..e118e709
--- /dev/null
+++ b/platform/linux-generic/arch/powerpc/odp_cpu.h
@@ -0,0 +1,10 @@
+/* Copyright (c) 2017, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#ifndef ODP_POWERPC_CPU_H_
+#define ODP_POWERPC_CPU_H_
+
+#endif
diff --git a/platform/linux-generic/arch/x86/odp_cpu.h
b/platform/linux-generic/arch/x86/odp_cpu.h
new file mode 100644
index 00000000..cdbef5c1
--- /dev/null
+++ b/platform/linux-generic/arch/x86/odp_cpu.h
@@ -0,0 +1,41 @@
+/* Copyright (c) 2017, Linaro Limited
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: BSD-3-Clause
+ */
+
+#ifndef ODP_X86_CPU_H_
+#define ODP_X86_CPU_H_
+
+/******************************************************************************
+ * Atomics
+ *****************************************************************************/
+
+#define atomic_store_release(loc, val, ro) \
+ __atomic_store_n(loc, val, __ATOMIC_RELEASE)
+
+/******************************************************************************
+ * Idle mgmt
+ *****************************************************************************/
+
+static inline void sevl(void)
+{
+ /* empty */
+}
+
+static inline int wfe(void)
+{
+ return 1;
+}
+
+#define monitor128(addr, mo) __atomic_load_n((addr), (mo))
+#define monitor64(addr, mo) __atomic_load_n((addr), (mo))
+#define monitor32(addr, mo) __atomic_load_n((addr), (mo))
+#define monitor8(addr, mo) __atomic_load_n((addr), (mo))
+
+static inline void doze(void)
+{
+ odp_cpu_pause();
+}
+
+#endif
