Dmitry Eremin-Solenikov(lumag) replied on github web page:
platform/linux-generic/odp_packet_io.c
line 12
@@ -485,6 +486,11 @@ int odp_pktio_start(odp_pktio_t hdl)
sched_fn->pktio_start(_odp_pktio_index(hdl), num, index, odpq);
}
+ if (ODP_PCAPNG) {
Comment:
And also it should be `_odp_pcapng_FOO`
> Dmitry Eremin-Solenikov(lumag) wrote:
> `_odp_smth...`
>> Dmitry Eremin-Solenikov(lumag) wrote:
>> Neat idea, but just put pcapng_prepare inside header and define it to empty
>> val if ODP_PCAPNG is undefined.
>> Also if it returns an error, it should not require one to call
>> pcapng_destroy() afterwards. Just make it clean up after itself in case of
>> an error.
>>> Dmitry Eremin-Solenikov(lumag) wrote:
>>> Just use one AC_DEFINE and check using `#ifdef` inside.
https://github.com/Linaro/odp/pull/488#discussion_r168844204
updated_at 2018-02-16 19:07:08
