As far as I am aware, the only difference is the two indentation spaces instead of four.

Since we are at it, the sunCodingConvention.xml file could be moved to under src/ instead of /. Moreover, since it's log4j conventions log4CodingConvention sounds right. Both of codingConvention or convention are OK too.

At 13:18 15.02.2003 -0800, you wrote:
Well, as far as I know, there is no Jakarta coding convention; every project
can do as it pleases.  But renaming it to log4jCodingConvention is a good
idea.

Ceki, are there any other variants on the Sun coding style that we already
know log4j uses?

-Mark

> -----Original Message-----
> From: Luis Reis [mailto:[EMAIL PROTECTED]]
> Sent: Saturday, February 15, 2003 1:25 PM
> To: Log4J Developers List
> Subject: RE: Indentation!!!
>
>
> Some food for thought:
>
> Why are you changing sunCodingConvention.xml instead of creating a
> jakartaCodingConvention or log4CodingConvention ?
>
> --
> Luis
>
>
> On Sat, 2003-02-15 at 19:15, [EMAIL PROTECTED] wrote:
>     Done.  I changed "continuation" and "general" from 4 to
> 2.  If there are any
>     other changes that should be applied, let me know.
>
>     -Mark
>
>     > -----Original Message-----
>     > From: Ceki Gulcu [mailto:[EMAIL PROTECTED]]
>     > Sent: Saturday, February 15, 2003 7:38 AM
>     > To: [EMAIL PROTECTED]
>     > Subject: Indentation!!!
>     >
>     >
>     >
>     > Mark,
>     >
>     > I'd just like to point out that although log4j
> generally adheres to Suns
>     > coding conventions, it uses 2 spaces for indentation
> and not 4. I would
>     > like to request that the file sunCodingConvention.xml
> be modified to
>     > reflect this difference. TIA,
>     >
>     >
>     > --
>     > Ceki
>     >
>     >
>     >
> ---------------------------------------------------------------------
>     > To unsubscribe, e-mail: [EMAIL PROTECTED]
>     > For additional commands, e-mail:
> [EMAIL PROTECTED]
>     >
>
>
>
> ---------------------------------------------------------------------
>     To unsubscribe, e-mail: [EMAIL PROTECTED]
>     For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
--
Ceki

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to