Hello Mark, In addition to making mods to build.xml, selector and servlet initializers, I also took the liberty of adding the mods to the sunCodingConvention.xml that we agreed to. So, make sure it isn't already there before you check anything in.
Jake Tuesday, February 18, 2003, 12:25:47 PM, you wrote: MW> I didn't get home from work until after midnight, so needless to say, I did MW> not check in the changes as promised. I will do it this evening though. MW> -Mark >> -----Original Message----- >> From: Mark Womack >> Sent: Monday, February 17, 2003 12:01 PM >> To: 'Log4J Developers List' >> Subject: RE: Indentation!!! >> >> >> Jake, >> >> Thanks. I'll check in the patch later tonight. >> >> Did you run into any other discrepencies between what jalopy >> changes and >> checkstyle checks? >> >> -Mark >> >> -----Original Message----- >> From: Jacob Kjome [mailto:[EMAIL PROTECTED]] >> Sent: Sunday, February 16, 2003 8:14 PM >> To: Log4J Developers List >> Subject: RE: Indentation!!! >> >> >> >> One thing that isn't being enforced is the order of keyword >> modifiers. The >> following change would enable that. >> >> change >> <modifier> >> >> <order>public|protected|private|abstract|static|final|synchron >> ized|transient >> |volatile|native|strictfp</order> >> </modifier> >> to >> <modifier> >> <enable>true</enable> >> >> <order>public|protected|private|abstract|static|final|synchron >> ized|transient >> |volatile|native|strictfp</order> >> </modifier> >> >> >> Otherwise, when you run Jalopy and your keywords are out of the order >> specified above, they won't get corrected and checkstyle will >> still report >> errors. >> >> As a side note, I can't figure out how to make work with >> Jalopy is changing >> single line comment lines to be 79 characters long or less. >> They remain >> unmodified where multi-line comments get corrected. Anyone >> know a way to do >> that? If not, then single line comments will always require >> hand-modification to bring them into compliance. Jalopy >> alone won't do the >> trick. >> >> >> Oh, one other thing... >> >> I order to run the "editJalopyPreferences" target, I had to move the >> following code from inside the "runJalopy" target to a place >> outside that >> target so both targets could see it: >> >> <path id="jalopy.path"> >> <fileset dir="${jalopy.lib}"> >> <include name="*.jar" /> >> </fileset> >> </path> >> >> >> I also made the jalopy targets which weren't depending on >> "init" to depend >> on init to be consistent with the other targets. I'm >> attaching a diff of my >> preferred changes against the current build.xml. >> >> Jake >> >> At 11:15 AM 2/15/2003 -0800, you wrote: >> >> >> Done. I changed "continuation" and "general" from 4 to 2. >> If there are any >> other changes that should be applied, let me know. >> >> -Mark >> >> > -----Original Message----- >> > From: Ceki Gulcu [ mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> ] >> > Sent: Saturday, February 15, 2003 7:38 AM >> > To: [EMAIL PROTECTED] >> > Subject: Indentation!!! >> > >> > >> > >> > Mark, >> > >> > I'd just like to point out that although log4j generally >> adheres to Suns >> > coding conventions, it uses 2 spaces for indentation and >> not 4. I would >> > like to request that the file sunCodingConvention.xml be modified to >> > reflect this difference. TIA, >> > >> > >> > -- >> > Ceki >> > >> > >> > >> --------------------------------------------------------------------- >> > To unsubscribe, e-mail: [EMAIL PROTECTED] >> > For additional commands, e-mail: [EMAIL PROTECTED] >> > >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAIL PROTECTED] >> >> MW> --------------------------------------------------------------------- MW> To unsubscribe, e-mail: [EMAIL PROTECTED] MW> For additional commands, e-mail: [EMAIL PROTECTED] -- Best regards, Jacob mailto:[EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
