Thanks. I'll update this setting as well. And yes, I think we should break up the classes into jars as you have listed. Go ahead and make the change in the build.xml. We can do whatever makes the most sense for the code that is in the the sandbox.
-Mark > -----Original Message----- > From: Jacob Kjome [mailto:[EMAIL PROTECTED]] > Sent: Monday, February 17, 2003 2:33 PM > To: Log4J Developers List > Subject: Re[2]: Indentation!!! > > > Hello Mark, > > Actually, yes, I found one more. > > under <wrapping><general>, change > > <beforeOperator>false</beforeOperator> > to > <beforeOperator>true</beforeOperator> > > checkstyle complains if the operator isn't on the next line. For > instance it doesn't like... > > String myString = "blahahahaha saldfjsaldfjalsdfjaslfjsfdj" + > "alsdjfasjdfasjfalsflsadfjalsfjsl"; > > > it likes... > > String myString = "blahahahaha saldfjsaldfjalsdfjaslfjsfdj" > + "alsdjfasjdfasjfalsflsadfjalsfjsl"; > > > Also, can we consider creating jars specific to the selectors and > servlet packages? > > I would propose: > > <property name="log4j-sandbox-selector.jar" > value="log4j-sandbox-selector-${version}.jar"/> > <property name="log4j-sandbox-servlet.jar" > value="log4j-sandbox-servlet-${version}.jar"/> > > and then <jar> entries for each just like the current sandbox jar. > > The reason for this is that selectors must be wherever log4j is and > servlet shouldn't be run from the shared class loaders. > > So, if log4j.jar is in CATALINA_HOME/common/lib, then the selectors > jar should be there as well but the servlet jar must *not* be there. > It must be in WEB-INF/lib of the webapp. > > We can still make the full jar, if you want, but it isn't very useful > for the selectors and servlets. > > Jake > > Monday, February 17, 2003, 2:01:21 PM, you wrote: > > MW> Jake, > > MW> Thanks. I'll check in the patch later tonight. > > MW> Did you run into any other discrepencies between what > jalopy changes and > MW> checkstyle checks? > > MW> -Mark > > MW> -----Original Message----- > MW> From: Jacob Kjome [mailto:[EMAIL PROTECTED]] > MW> Sent: Sunday, February 16, 2003 8:14 PM > MW> To: Log4J Developers List > MW> Subject: RE: Indentation!!! > > > > MW> One thing that isn't being enforced is the order of > keyword modifiers. The > MW> following change would enable that. > > MW> change > MW> <modifier> > > MW> > <order>public|protected|private|abstract|static|final|synchron > ized|transient > MW> |volatile|native|strictfp</order> > MW> </modifier> > MW> to > MW> <modifier> > MW> <enable>true</enable> > > MW> > <order>public|protected|private|abstract|static|final|synchron > ized|transient > MW> |volatile|native|strictfp</order> > MW> </modifier> > > > MW> Otherwise, when you run Jalopy and your keywords are out > of the order > MW> specified above, they won't get corrected and checkstyle > will still report > MW> errors. > > MW> As a side note, I can't figure out how to make work with > Jalopy is changing > MW> single line comment lines to be 79 characters long or > less. They remain > MW> unmodified where multi-line comments get corrected. > Anyone know a way to do > MW> that? If not, then single line comments will always require > MW> hand-modification to bring them into compliance. Jalopy > alone won't do the > MW> trick. > > > MW> Oh, one other thing... > > MW> I order to run the "editJalopyPreferences" target, I had > to move the > MW> following code from inside the "runJalopy" target to a > place outside that > MW> target so both targets could see it: > > MW> <path id="jalopy.path"> > MW> <fileset dir="${jalopy.lib}"> > MW> <include name="*.jar" /> > MW> </fileset> > MW> </path> > > > MW> I also made the jalopy targets which weren't depending on > "init" to depend > MW> on init to be consistent with the other targets. I'm > attaching a diff of my > MW> preferred changes against the current build.xml. > > MW> Jake > > MW> At 11:15 AM 2/15/2003 -0800, you wrote: > > > MW> Done. I changed "continuation" and "general" from 4 to > 2. If there are any > MW> other changes that should be applied, let me know. > > MW> -Mark > > >> -----Original Message----- > >> From: Ceki Gulcu [ mailto:[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]> ] > >> Sent: Saturday, February 15, 2003 7:38 AM > >> To: [EMAIL PROTECTED] > >> Subject: Indentation!!! > >> > >> > >> > >> Mark, > >> > >> I'd just like to point out that although log4j generally > adheres to Suns > >> coding conventions, it uses 2 spaces for indentation and > not 4. I would > >> like to request that the file sunCodingConvention.xml be > modified to > >> reflect this difference. TIA, > >> > >> > >> -- > >> Ceki > >> > >> > >> > --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [EMAIL PROTECTED] > >> For additional commands, e-mail: [EMAIL PROTECTED] > >> > > > MW> > --------------------------------------------------------------------- > MW> To unsubscribe, e-mail: [EMAIL PROTECTED] > MW> For additional commands, e-mail: [EMAIL PROTECTED] > > > > > -- > Best regards, > Jacob mailto:[EMAIL PROTECTED] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
