DO NOT REPLY [Bug 24803] - LevelMatchFilter not working as expected

[bugzilla]

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
<http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24803>.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=24803

LevelMatchFilter not working as expected





------- Additional Comments From [EMAIL PROTECTED]  2003-11-19 15:19 -------
Paul,

I have just recently noticed the same problem. The problem is within the decide
method. The problem is if it does not find a match it will return Filter.NEUTRAL
and this implies that the message can be logged. 

I would consider changing the code from:

    if(matchOccured) {  
      if(this.acceptOnMatch)
          return Filter.ACCEPT;
      else
          return Filter.DENY;
    } else {
      return Filter.NEUTRAL;
    }

to:

    if(this.acceptOnMatch) {
      if(matchOccured)
          return Filter.ACCEPT;
      else
          return Filter.DENY;
    } else {
      return Filter.NEUTRAL;
    }

This seems to be the correct logic IMO.

Again, this needs to be reviewed by the log4j group.

--Claudio

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]