Yoav,
This change does not compile. The ErrorHandler interface does not support error(String,Exception). Not sure how you want to resolve this. I took a quick look, and there are methods that take an Exception, but they also require other parameters, like an error code.
[javac] D:\development\code-cvs-jakarta-projects\logging-log4j\src\java\org\apache\log4j\net\SMTPAppender.java:258: cannot resolve symbol
[javac] symbol : method error (java.lang.String,java.lang.Exception)
[javac] location: interface org.apache.log4j.spi.ErrorHandler
[javac] errorHandler.error("Error occured while sending e-mail notification.", e);
[javac] ^
[javac] 1 error
-Mark
----- Original Message ----- From: <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Monday, December 13, 2004 8:22 AM
Subject: cvs commit: logging-log4j/src/java/org/apache/log4j/net SMTPAppender.java
yoavs 2004/12/13 08:22:14
Modified: docs HISTORY.txt
src/java/org/apache/log4j/net SMTPAppender.java
Log:
Bugzilla 13900: SMTPAppender doesn't use errorHandler when sending errors occur.
Revision Changes Path 1.9 +2 -0 logging-log4j/docs/HISTORY.txt
Index: HISTORY.txt =================================================================== RCS file: /home/cvs/logging-log4j/docs/HISTORY.txt,v retrieving revision 1.8 retrieving revision 1.9 diff -u -r1.8 -r1.9 --- HISTORY.txt 13 Dec 2004 16:12:36 -0000 1.8 +++ HISTORY.txt 13 Dec 2004 16:22:14 -0000 1.9 @@ -23,6 +23,8 @@
- Fixed Bugzilla 18076: setting of firstTime in OnlyOnceErrorHandler.
+ - Fixed Bugzilla 13900: SMTPAppender doesn't use errorHandler when sending error occurs.
+
November 25, 2004
- Release of version 1.3alpha-3
1.36 +1 -1 logging-log4j/src/java/org/apache/log4j/net/SMTPAppender.java
Index: SMTPAppender.java
===================================================================
RCS file: /home/cvs/logging-log4j/src/java/org/apache/log4j/net/SMTPAppender.java,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -r1.35 -r1.36
--- SMTPAppender.java 20 Nov 2004 15:46:02 -0000 1.35
+++ SMTPAppender.java 13 Dec 2004 16:22:14 -0000 1.36
@@ -255,7 +255,7 @@
msg.setSentDate(new Date());
Transport.send(msg);
} catch (Exception e) {
- getLogger().error("Error occured while sending e-mail notification.", e);
+ errorHandler.error("Error occured while sending e-mail notification.", e);
}
}
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
