https://issues.apache.org/bugzilla/show_bug.cgi?id=44157
--- Comment #4 from Jared Oberhaus <[EMAIL PROTECTED]> 2008-08-13 16:40:00 PST --- This is great, thank you! I took a look at the change, and here's what I observed: * java/org/apache/log4j/PropertyConfigurator.java * java/org/apache/log4j/xml/DOMConfigurator.java There are a few catch(Exception) and catch(Throwable) that could also be hiding InterruptedException. * java/org/apache/log4j/jmx/AbstractDynamicMBean.java * java/org/apache/log4j/jmx/Agent.java * java/org/apache/log4j/jmx/AppenderDynamicMBean.java * java/org/apache/log4j/jmx/HierarchyDynamicMBean.java * java/org/apache/log4j/jmx/LayoutDynamicMBean.java There are couple of catch(Exception) here that do nothing but printStackTrace(). This hides InterruptedException and InterruptedIOException, but I suspect that the intent of those catches is that they never happen... But there are still others that appear to be normal operation and will hide InterruptedException. * java/org/apache/net/JMSAppender.java There's a catch(Exception) in the close() method * java/org/apache/net/JMSSink.java There's a catch(Exception) in the constructor * java/org/apache/net/SMTPAppender.java In sendBuffere there's a catch(Exception) * java/org/apache/net/SocketAppender.java In the connect() method there's a catch(IOException) that might call errorHandler.error, but in other cases will not, in which case the InterruptedException will be lost... * java/org/apache/net/SocketHubAppender.java There are catch(IOException) in cleanup() and append() that will hide InterruptedIOException. * java/org/apache/net/TelnetAppender.java There are a few ignored catch(Exception) and one ignored catch(InterruptedException) * java/org/apache/log4j/spi/LoggingEvent.java There's a catch(Exception) here * java/org/apache/log4j/varia/ExternallyRolledFileAppender.java The class HUP extends Thread and checks for isInterrupted(), but the catch(Exception) block will effectively eat any that are thrown. Also there are a couple other catch(Exception) in that file. * java/org/apache/log4j/varia/Roller.java There's a catch(IOException) here too, but it calls System.exit(2). * java/org/apache/log4j/chainsaw/... There are several files in here that catch(Exception); however, this isn't nearly as critical as the InterruptedException's lost above, because chainsaw is usually its own standalone tool. * java/org/apache/log4j/lf5/... Like chainsaw, this probably isn't as important as the above, as it's a standalone tool. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
