https://issues.apache.org/bugzilla/show_bug.cgi?id=44157





--- Comment #7 from Curt Arnold <[EMAIL PROTECTED]>  2008-08-14 23:01:19 PST ---
Applied everything in comment 6 in rev 686149 except:

> java/org/apache/log4j/net/SocketHubAppender.java:428
> ignored InterruptedIOException; the comment says that it's a timeout,
> but a timeout will usually cause SocketTimeoutException.

SocketTimeoutException was added in JDK 1.4 and extends InterruptedIOException.
 The only way to catch the timeout JDK 1.3 and earlier is to catch the
InterruptedIOException.  I think the logic is doing what it needs to do.

There is the unlikely possibility that InstantiationExceptions are also masking
InterruptedExceptions or InterruptedIOExceptions however
InstantiationException.getCause() was added in JDK 1.4.  I do not feel that it
is worth doing a reflective call to check for the underlying exception.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to