https://issues.apache.org/bugzilla/show_bug.cgi?id=44157
--- Comment #6 from Jared Oberhaus <[EMAIL PROTECTED]> 2008-08-14 15:25:57 PST --- Thanks again for your change. Looks great... First, I have to admit that my feedback in Comment #4 was based on my reviewing an older copy of log4j, not the latest trunk. Please accept my apologies for this... I am rectifying that now by checking out the latest trunk and looking it over. Here is what I've observed: * Ignoring issues in contribs/... * Ignoring issues in examples/... * Ignoring issues in tests/... * Ignoring chainsaw and lf5 (thanks for the info in Comment #5) * catch(Throwable), catch(Exception), catch(InvocationTargetException) There are cases I've found of catch(InvocationTargetException), and of catch(Throwable) and catch(Exception). In the case where InvocationTargetException is thrown, the result of getTargetException could be an InterruptedException or an InterruptedIOException. Also, the Throwable or Exception could be InterruptedException or InterruptedIOException, or an InvocationTargetException with InterruptedException or InterruptedIOException in getTargetException. Perhaps a utility method could be used (similar to ErrorHandler.error) that analyzes all of these cases. Note that I now realize I should audit my own code for these cases, as I also use Method.invoke and catch(InvocationTargetException)... Here's a list of the places where I found either catch(Throwable), catch(Exception) or catch(InvocationTargetException) and it seemed that one of these exceptions was possible (I'm ignoring cases where Throwable/Exception couldn't include one of the 3 above exceptions): java/org/apache/log4j/config/PropertyGetter.java:80 java/org/apache/log4j/config/PropertySetter.java:145 java/org/apache/log4j/config/PropertySetter.java:229 java/org/apache/log4j/helpers/Loader.java:115 java/org/apache/log4j/helpers/Loader.java:175 java/org/apache/log4j/helpers/OptionConverter.java:233 java/org/apache/log4j/helpers/OptionConverter.java:331 java/org/apache/log4j/jmx/Agent.java:85 java/org/apache/log4j/jmx/AppenderDynamicMBean.java:254 java/org/apache/log4j/jmx/AppenderDynamicMBean.java:310 java/org/apache/log4j/jmx/LayoutDynamicMBean.java:192 java/org/apache/log4j/jmx/LayoutDynamicMBean.java:250 java/org/apache/log4j/net/SocketNode.java:106 java/org/apache/log4j/spi/LocationInfo.java:170 java/org/apache/log4j/spi/LoggingEvent.java:441 java/org/apache/log4j/xml/DOMConfigurator.java:406 * java/org/apache/log4j/net/SocketHubAppender.java:374 Ignored InterruptedException * java/org/apache/log4j/net/TelnetAppender.java:108 Ignored InterruptedException * java/org/apache/log4j/net/SocketHubAppender.java:428 ignored InterruptedIOException; the comment says that it's a timeout, but a timeout will usually cause SocketTimeoutException. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
