2012/6/5 ceki <c...@qos.ch>: > On 01.06.2012 04:41, Ralph Goers wrote: >> >> If you don't do that then you end up with a bunch of optional >> dependencies that you will forget to include or a bunch of required >> dependencies that you may not really need. >> >> Separating the API from the impl is useful as it keeps users from >> accessing stuff that wasn't meant to be public - which is one of the >> more serious problems in 1.x. >> >> Ralph > > > Agreed. Separating chainsaw and lf5 into new modules is most > reasonable. However, modularization can be easily overdone. Assuming > the code in org.apache.log4j.net has not changed much since the last > time I looked, I would recommend that the org.apache.log4j.net be part > of the core module, not separate.
It's not a question of the module themselves, but a question about the dependency they carry with them. In this case, "net" module carries the javax.mail dependency, that you need only if you want to use it. IOW, you should put yourself in the shoes of the Maven users: if he/she does not want to use mail, he/she has to exclude it. If you flag it as optional, it is not obvious for the user that he/she has to include it. So guess what is the solution? Right, modules :-) Antonio --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org
