I am sorry that I didn't express myself better. For some reason I thought everybody would know about the couchdb/couchbase issue.

I have committed the change to svn.

Sorry that I don't know if I should have opened an issue for this or add an entry to changes.xml, maybe one can remind me...

And Nick: would you accept to rename mongo to mongodb for the same reasons? The products name is mongodb actually. At the moment there is nobody having some kind of mongobase to my knowledge but maybe we are better being prepared... to many database vendors these days. What do you think?

Thanks!


On 7 Feb 2014, at 17:55, Nick Williams wrote:

Ohhh okay. I misunderstood. Hmmmm. Well I suppose in that case we really must rename it, although I'm not super happy about it. But I'm convinced it's necessary.

I guess we rename the "couch" package to "couchdb."

Nick

On Feb 7, 2014, at 10:23 AM, Christian Grobmeier wrote:

folks thats what i meant.

Couchbase is a different database than CouchDB. They share the same roots,
but meanwhile have some differences.

My guess is one needs a second appender.

The one we have seems to work with couchdb, so the package should be named couchdb.
If we want to support couchbase, we need a new implementation

Its more precise. Nobody would just say "log4" because its clear that we mean java.

If I could convince you now, I would like to rename mongo to mongodb too.

As Scott mentioned I would like to convince you (Nick) first, before I do any change.

Hope this happened now :)






On 7 Feb 2014, at 17:16, Scott Deboy wrote:


I would appreciate if there wasn't even a threat of veto.

I would like to see folks ask questions and talk about concerns, and then
only mention a veto when there is no other recourse.
On Feb 7, 2014 8:14 AM, "Nick Williams" <nicho...@nicholaswilliams.net>
wrote:

Yep. I would've accompanied any veto with technical justification. Since I can't come up with a technical justification for renaming it to couchbase,
I won't veto it. :-)

N

On Feb 7, 2014, at 10:09 AM, Scott Deboy wrote:

I do want to remind everyone that vetoes are only valid if they are backed
by a technical justification.

Scott
On Feb 7, 2014 8:07 AM, "Nick Williams" <nicho...@nicholaswilliams.net>
wrote:

I'm not convinced it really makes a difference, but it's better than couchdb, so if the majority wants couchbase it I won't veto it. Be sure to
change the test package name, too.

Nick

On Feb 7, 2014, at 10:03 AM, Scott Deboy wrote:

+1 to couchbase
On Feb 7, 2014 7:54 AM, "Christian Grobmeier" <grobme...@gmail.com>
wrote:

On 7 Feb 2014, at 16:19, Nick Williams wrote:

It doesn't so much matter because the XML element names are case
insensitive, but if we change the plugin name for CouchDB we should probably also change it for MongoDB. There's a reason I did that, I just
can't remember what it was...

I don't see any compelling reason to rename the package. The package name for MongoDB is "mongo." I don't like combining multiple words into a single package name segment, because we can't camel case them (bad practice to have cap letters in package names). Show me another NoSQL database with
the word "couch" in it and I'll reconsider. :-)


couchbase maybe?



N

On Feb 7, 2014, at 9:12 AM, Christian Grobmeier wrote:

also the packagename is just "couch", but it should better be
"couchdb".
The name couch is misleading imho

On 7 Feb 2014, at 16:11, Christian Grobmeier wrote:

Hi

one minor thing in ClouchDBProvider:

* The Apache CouchDB implementation of {@link NoSQLProvider}.
*/
@Plugin(name = "CouchDb", category = "Core", printObject = true)
public final class CouchDBProvider

The name of this plugin is "CouchDb" while the correct name of the
product
is CouchDB: couchdb.apache.org
Also our class and the comments do use the correct name. Just the
plugin
name is lower case.

Any objections if I would change the plugin name to CouchDB instead
of CouchDb?

Cheers



---
http://www.grobmeier.de
The Zen Programmer: http://bit.ly/12lC6DL
@grobmeier
GPG: 0xA5CC90DB

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-dev-h...@logging.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



---
http://www.grobmeier.de
The Zen Programmer: http://bit.ly/12lC6DL
@grobmeier
GPG: 0xA5CC90DB

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org






---
http://www.grobmeier.de
The Zen Programmer: http://bit.ly/12lC6DL
@grobmeier
GPG: 0xA5CC90DB

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org


---
http://www.grobmeier.de
The Zen Programmer: http://bit.ly/12lC6DL
@grobmeier
GPG: 0xA5CC90DB

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscr...@logging.apache.org
For additional commands, e-mail: log4j-dev-h...@logging.apache.org

Reply via email to