Cool! I hope it's coming along nicely :-) Gary
On Wed, Sep 3, 2014 at 3:16 PM, Matt Sicker <[email protected]> wrote: > I'm working on the constructors thing. Make the API a bit nicer. > > > On 3 September 2014 12:19, Gary Gregory <[email protected]> wrote: > >> Matt, feel free to whack on iostreams, I'm done in there for today. >> >> Gary >> >> >> On Wed, Sep 3, 2014 at 12:13 PM, Matt Sicker <[email protected]> wrote: >> >>> That's still a possibility, but I'm still not sold on it. >>> >>> >>> On 3 September 2014 11:04, Gary Gregory <[email protected]> wrote: >>> >>>> Then what about matching the module name? log4j-io? >>>> >>>> Gary >>>> >>>> >>>> On Wed, Sep 3, 2014 at 9:17 AM, Matt Sicker <[email protected]> wrote: >>>> >>>>> I'll take a look at the constructors and such. I think this is a prime >>>>> candidate for the builder pattern. >>>>> >>>>> Also, I renamed the o.a.l.l.streams package to o.a.l.l.io to match >>>>> the java.io package that this module emulates. I think it's a pretty >>>>> neat package name now (especially with the foo.io domain name fad >>>>> going on), but if there are objections, we can always name it something >>>>> else. >>>>> >>>>> >>>>> On 2 September 2014 23:59, Gary Gregory <[email protected]> >>>>> wrote: >>>>> >>>>>> On Wed, Sep 3, 2014 at 12:32 AM, Matt Sicker <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> They almost seem like SPI classes in a sense of how the JDK >>>>>>> categorizes things sometimes. I wouldn't mind flattening them. They're >>>>>>> all >>>>>>> of equal importance. >>>>>>> >>>>>> >>>>>> Done. >>>>>> >>>>>> I'm going to sleep now (1am here) but one thing you can look at Matt >>>>>> (or anyone) is how many of all the ctors we really need. There are quite >>>>>> a >>>>>> few. >>>>>> >>>>>> Gary >>>>>> >>>>>> >>>>>>> >>>>>>> On 2 September 2014 09:54, Gary Gregory <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Any thoughts on folding the two classes in >>>>>>>> >>>>>>>> org.apache.logging.log4j.streams.util >>>>>>>> >>>>>>>> back into: >>>>>>>> >>>>>>>> org.apache.logging.log4j.streams >>>>>>>> >>>>>>>> They are both hard wired to an ExtendedLogger. >>>>>>>> >>>>>>>> I could see those being a Core or API util package if they are to >>>>>>>> be in one. >>>>>>>> >>>>>>>> Thoughts? >>>>>>>> >>>>>>>> Gary >>>>>>>> >>>>>>>> -- >>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>> Home: http://garygregory.com/ >>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Matt Sicker <[email protected]> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> E-Mail: [email protected] | [email protected] >>>>>> Java Persistence with Hibernate, Second Edition >>>>>> <http://www.manning.com/bauer3/> >>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>> Blog: http://garygregory.wordpress.com >>>>>> Home: http://garygregory.com/ >>>>>> Tweet! http://twitter.com/GaryGregory >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Matt Sicker <[email protected]> >>>>> >>>> >>>> >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> Java Persistence with Hibernate, Second Edition >>>> <http://www.manning.com/bauer3/> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>> Spring Batch in Action <http://www.manning.com/templier/> >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> Matt Sicker <[email protected]> >>> >> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > Matt Sicker <[email protected]> > -- E-Mail: [email protected] | [email protected] Java Persistence with Hibernate, Second Edition <http://www.manning.com/bauer3/> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> Spring Batch in Action <http://www.manning.com/templier/> Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory
