The only other idea I had was StreamFactory.
On 4 September 2014 15:50, Gary Gregory <[email protected]> wrote: > I picked IoBuilder. Please fiddle or change as you see fit. > > Gary > > > On Thu, Sep 4, 2014 at 4:42 PM, Gary Gregory <[email protected]> > wrote: > >> >> >> >> On Thu, Sep 4, 2014 at 4:11 PM, Matt Sicker <[email protected]> wrote: >> >>> I think you're on to something! >>> >> >> I would pick IoBuilder because echoing the package name is more obvious >> than echoing the module name. >> >> Gary >> >>> >>> >>> On 4 September 2014 13:58, Gary Gregory <[email protected]> wrote: >>> >>>> On Thu, Sep 4, 2014 at 2:10 PM, Matt Sicker <[email protected]> wrote: >>>> >>>>> Updated the test. And as for the class name, something short would be >>>>> nice. >>>>> >>>> >>>> - IoBuilder echoes the package name >>>> - IoStreamsBuilder echoes the module name >>>> >>>> ? >>>> >>>> Gary >>>> >>>> >>>>> >>>>> >>>>> On 4 September 2014 12:23, Matt Sicker <[email protected]> wrote: >>>>> >>>>>> Whoops, I'll update that test. I didn't notice it. >>>>>> >>>>>> >>>>>> On 4 September 2014 12:18, Gary Gregory <[email protected]> >>>>>> wrote: >>>>>> >>>>>>> It looks like you did not update or push >>>>>>> org.apache.logging.log4j.io.LoggerPrintWriterJdbcH2Test >>>>>>> >>>>>>> Gary >>>>>>> >>>>>>> >>>>>>> On Thu, Sep 4, 2014 at 1:02 PM, Matt Sicker <[email protected]> >>>>>>> wrote: >>>>>>> >>>>>>>> Pushed the great refactoring. Turned out better than expected! >>>>>>>> >>>>>>>> >>>>>>>> On 3 September 2014 20:58, Matt Sicker <[email protected]> wrote: >>>>>>>> >>>>>>>>> I'm finding that there may be many different ways to expose this >>>>>>>>> API better than with constructors, and it's tough to choose a proper >>>>>>>>> way to >>>>>>>>> do it. Each class can have its own builder (very repetitive; can't >>>>>>>>> even >>>>>>>>> abstract it due to method chaining), or what I'm thinking might be >>>>>>>>> useful >>>>>>>>> is a more generic builder system that creates the appropriate class >>>>>>>>> based >>>>>>>>> on how it's configured. I'd like to take that approach, the >>>>>>>>> java.io API really shows its age with the huge lack of interfaces >>>>>>>>> and other more "modern" Java idioms. Then again, even Java 1.4 >>>>>>>>> screwed up >>>>>>>>> the logging API, so I'm not surprised. ;) >>>>>>>>> >>>>>>>>> I'm going to have more time to work on things over the next two >>>>>>>>> days as I'm on "staycation" with not much planned. Should have >>>>>>>>> something >>>>>>>>> neat by the weekend! >>>>>>>>> >>>>>>>>> >>>>>>>>> On 3 September 2014 17:44, Gary Gregory <[email protected]> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>>> Cool! I hope it's coming along nicely :-) >>>>>>>>>> >>>>>>>>>> Gary >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Wed, Sep 3, 2014 at 3:16 PM, Matt Sicker <[email protected]> >>>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> I'm working on the constructors thing. Make the API a bit nicer. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 3 September 2014 12:19, Gary Gregory <[email protected]> >>>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Matt, feel free to whack on iostreams, I'm done in there for >>>>>>>>>>>> today. >>>>>>>>>>>> >>>>>>>>>>>> Gary >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Sep 3, 2014 at 12:13 PM, Matt Sicker <[email protected]> >>>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> That's still a possibility, but I'm still not sold on it. >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On 3 September 2014 11:04, Gary Gregory < >>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Then what about matching the module name? log4j-io? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Gary >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Wed, Sep 3, 2014 at 9:17 AM, Matt Sicker <[email protected] >>>>>>>>>>>>>> > wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> I'll take a look at the constructors and such. I think this >>>>>>>>>>>>>>> is a prime candidate for the builder pattern. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Also, I renamed the o.a.l.l.streams package to o.a.l.l.io >>>>>>>>>>>>>>> to match the java.io package that this module emulates. I >>>>>>>>>>>>>>> think it's a pretty neat package name now (especially with the >>>>>>>>>>>>>>> foo.io domain name fad going on), but if there are >>>>>>>>>>>>>>> objections, we can always name it something else. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 September 2014 23:59, Gary Gregory < >>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Wed, Sep 3, 2014 at 12:32 AM, Matt Sicker < >>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> They almost seem like SPI classes in a sense of how the >>>>>>>>>>>>>>>>> JDK categorizes things sometimes. I wouldn't mind flattening >>>>>>>>>>>>>>>>> them. They're >>>>>>>>>>>>>>>>> all of equal importance. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Done. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I'm going to sleep now (1am here) but one thing you can >>>>>>>>>>>>>>>> look at Matt (or anyone) is how many of all the ctors we >>>>>>>>>>>>>>>> really need. There >>>>>>>>>>>>>>>> are quite a few. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Gary >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 September 2014 09:54, Gary Gregory < >>>>>>>>>>>>>>>>> [email protected]> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Any thoughts on folding the two classes in >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> org.apache.logging.log4j.streams.util >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> back into: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> org.apache.logging.log4j.streams >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> They are both hard wired to an ExtendedLogger. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I could see those being a Core or API util package if >>>>>>>>>>>>>>>>>> they are to be in one. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thoughts? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Gary >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>>>>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>>>>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>>>>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>>>>>>>>>> <http://www.manning.com/tahchiev/> >>>>>>>>>>>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>>>>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>>> Matt Sicker <[email protected]> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>>>>>>>> <http://www.manning.com/tahchiev/> >>>>>>>>>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Matt Sicker <[email protected]> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>>>>>> <http://www.manning.com/tahchiev/> >>>>>>>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Matt Sicker <[email protected]> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>>>> <http://www.manning.com/tahchiev/> >>>>>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Matt Sicker <[email protected]> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> E-Mail: [email protected] | [email protected] >>>>>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>>>>> <http://www.manning.com/bauer3/> >>>>>>>>>> JUnit in Action, Second Edition >>>>>>>>>> <http://www.manning.com/tahchiev/> >>>>>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>>>>> Blog: http://garygregory.wordpress.com >>>>>>>>>> Home: http://garygregory.com/ >>>>>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Matt Sicker <[email protected]> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Matt Sicker <[email protected]> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> E-Mail: [email protected] | [email protected] >>>>>>> Java Persistence with Hibernate, Second Edition >>>>>>> <http://www.manning.com/bauer3/> >>>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>>>>> Spring Batch in Action <http://www.manning.com/templier/> >>>>>>> Blog: http://garygregory.wordpress.com >>>>>>> Home: http://garygregory.com/ >>>>>>> Tweet! http://twitter.com/GaryGregory >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Matt Sicker <[email protected]> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Matt Sicker <[email protected]> >>>>> >>>> >>>> >>>> >>>> -- >>>> E-Mail: [email protected] | [email protected] >>>> Java Persistence with Hibernate, Second Edition >>>> <http://www.manning.com/bauer3/> >>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >>>> Spring Batch in Action <http://www.manning.com/templier/> >>>> Blog: http://garygregory.wordpress.com >>>> Home: http://garygregory.com/ >>>> Tweet! http://twitter.com/GaryGregory >>>> >>> >>> >>> >>> -- >>> Matt Sicker <[email protected]> >>> >> >> >> >> -- >> E-Mail: [email protected] | [email protected] >> Java Persistence with Hibernate, Second Edition >> <http://www.manning.com/bauer3/> >> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> >> Spring Batch in Action <http://www.manning.com/templier/> >> Blog: http://garygregory.wordpress.com >> Home: http://garygregory.com/ >> Tweet! http://twitter.com/GaryGregory >> > > > > -- > E-Mail: [email protected] | [email protected] > Java Persistence with Hibernate, Second Edition > <http://www.manning.com/bauer3/> > JUnit in Action, Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > -- Matt Sicker <[email protected]>
