Hi, will do as soon as I got some spare time. I already checked out the trunk. I have to admit that my solution is a bit dirty (imho) and there's a warning when validating a config that uses KeyValuePairs on Appenders. When I make a diff I'll patch the original classes and thus make sure that everything is set up nicely.
Best Regards, Alex -----Ursprüngliche Nachricht----- Von: Remko Popma [mailto:remko.po...@gmail.com] Gesendet: Mittwoch, 16. Oktober 2013 16:40 An: Log4J Users List Betreff: Re: Log4j2 Appender attributes with strict xml config On Wednesday, October 16, 2013, Gary Gregory wrote: > On Wed, Oct 16, 2013 at 8:48 AM, Remko Popma > <remko.po...@gmail.com<javascript:;>> > wrote: > > > Perfection may be hard to achieve, but if Alexander's suggestions > > are an improvement over the current schema, should we add them to > > the current > code > > base? > > > > Probably but where are they? It looks like some text was lost in a > reply to this thread. > > Gary Hm, it's a bit hard to do this via mail (but perhaps that's just me...) Alexander, would you mind raising a JIRA ticket and appending your modifications to it? A diff patch file would be ideal. Best regards, Remko > > > Remko > > > > On Tuesday, October 15, 2013, Gary Gregory wrote: > > > > > On Mon, Oct 14, 2013 at 11:10 AM, Ralph Goers > > > <ralph.go...@dslextreme.com <javascript:;> <javascript:;>> wrote: > > > > > > > > On Oct 14, 2013, at 7:31 AM, Gary Gregory > > > > <garydgreg...@gmail.com<javascript:;> > > <javascript:;>> > > > wrote: > > > > > > > >> The current idea I have is that the XML Schema would reflect > > > >> exactly the code that is running. We should start with that. > > > >> AFAIK, the current code we have does not allow open-ended XML > > > >> fragments, but I could be wrong... > > > >> > > > >> Gary > > > > > > > > Of course it allows open-ended XML fragments. If the user > > > > provides > > > their own Appender as a plugin they are free to create other > > > plugins > that > > > the Appender can then reference. The same is true for Filters, > Lookups, > > > etc. XMLConfiguration and JSONConfiguration don't care about > > > specific element names - only that they map to a defined plugin. > > > So any scheme > > you > > > come up with to generate a fully strict schema would have to be > > > able to account for user defined plugins. > > > > > > I should have been more specific, or there is another piece I do > > > not understand. > > > > > > If I or Alexander provide our own Appender, they will be annotated > > > with Log4j2 annotations. Today, yes, the XML is open-ended, but > > > not per XML Schema. In my imaginary yet-to-be-implemented system, > > > you would tell Log4j, at developement or build time of your app, > > > to rebuild the metadata such that: (1) the normal config knows > > > about my custom appender, and (2) I can generate a new XML Schema. > > > > > > Gary > > > > > > > > > > > Ralph > > > > ---------------------------------------------------------------- > > > > ----- To unsubscribe, e-mail: > > > > log4j-user-unsubscr...@logging.apache.org<javascript:;> > > <javascript:;> > > > > For additional commands, e-mail: > > > > log4j-user-h...@logging.apache.org<javascript:;> > > <javascript:;> > > > > > > > > > > > > > > > > -- > > > E-Mail: garydgreg...@gmail.com <javascript:;> <javascript:;> | > ggreg...@apache.org <javascript:;> > > <javascript:;> > > > Java Persistence with Hibernate, Second Edition JUnit in Action, > > > Second Edition Spring Batch in Action > > > Blog: http://garygregory.wordpress.com > > > Home: http://garygregory.com/ > > > Tweet! http://twitter.com/GaryGregory > > > > > > ------------------------------------------------------------------ > > > --- To unsubscribe, e-mail: > > > log4j-user-unsubscr...@logging.apache.org<javascript:;> > > <javascript:;> > > > For additional commands, e-mail: > > > log4j-user-h...@logging.apache.org<javascript:;> > > <javascript:;> > > > > > > > > > > > > -- > E-Mail: garydgreg...@gmail.com <javascript:;> | > ggreg...@apache.org<javascript:;> Java Persistence with Hibernate, > Second Edition< http://www.manning.com/bauer3/> JUnit in Action, > Second Edition <http://www.manning.com/tahchiev/> > Spring Batch in Action <http://www.manning.com/templier/> > Blog: http://garygregory.wordpress.com > Home: http://garygregory.com/ > Tweet! http://twitter.com/GaryGregory > --------------------------------------------------------------------- To unsubscribe, e-mail: log4j-user-unsubscr...@logging.apache.org For additional commands, e-mail: log4j-user-h...@logging.apache.org
