Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601024
--- Diff: src/Util/ReadOnlyPropertiesDictionary.cs ---
@@ -215,8 +216,13 @@ public virtual void GetObjectData(SerializationInfo
info, StreamingContext conte
string entryKey = entry.Key as string;
object entryValue = entry.Value;
- // If value is serializable then we add it to
the list
- if (entryKey != null && entryValue != null &&
entryValue.GetType().IsSerializable)
+ // If value is serializable then we add it to the list
+#if NETSTANDARD1_3
+ bool isSerializable =
entryValue.GetType().GetTypeInfo().IsSerializable;
+#else
+ bool isSerializable = entryValue.GetType().IsSerializable;
+#endif
+ if (entryKey != null && entryValue != null &&
isSerializable)
{
--- End diff --
nit: indentation under `#if` `#else` and that of `if (entryKey` is off
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
