Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r70601430
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
/// </remarks>
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
Should we just ToLower(), compare with `==` and get rid of the
preprocessors for all Compare()-like code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
