Github user jasonwilliams200OK commented on a diff in the pull request:
https://github.com/apache/log4net/pull/16#discussion_r74683879
--- Diff: src/Util/PatternStringConverters/NewLinePatternConverter.cs ---
@@ -72,6 +75,16 @@ internal sealed class NewLinePatternConverter :
LiteralPatternConverter, IOption
/// </remarks>
public void ActivateOptions()
{
+#if NETSTANDARD1_3
+ if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "DOS",
CompareOptions.IgnoreCase) == 0)
+ {
+ Option = "\r\n";
+ }
+ else if
(CultureInfo.InvariantCulture.CompareInfo.Compare(Option, "UNIX",
CompareOptions.IgnoreCase) == 0)
--- End diff --
@chlowell, do you think it's a good idea to instead of dogfooding
`string.Compare(strA, strB, InvariantCulture) == 0` pattern with `CultureInfo`
comparer, use common denominator `strA.ToUpperInvariant() ==
strB.ToUpperInvariant()` and remove the preprocessor all over the place as part
of this PR? IMO, this will clean up quite a bit. If you want, I can send a PR
to your `log4net-core-pcl` branch, then you would just need to update the JIRA
patch. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
