[
https://issues.apache.org/jira/browse/LOG4PHP-108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861821#action_12861821
]
Ivan Habunek commented on LOG4PHP-108:
--------------------------------------
I have a couple of issues with this patch.
Firstly, do you think it's a good idea to have addHTMLLineBreak default to
true? This changes the current default behaviour. I mostly develop command line
apps so this was not welcome on my part.
Secondly, you append <br/> to end of the mesage if this option is enabled.
Wouldn't it be neater to replace all line breaks in the message with <br />? I
often log multi-line messages so from my perspective this would be the better
approach.
Also, I think you broke one of the tests with this patch:
1) LoggerRendererMapTest::testUsage
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
ERROR - test1,test2,test3
-<br />
+
D:\Dev\log4php\src\test\php\renderers\LoggerRendererMapTest.php:82
> Add HTML line break to LoggerAppenderEcho output
> ------------------------------------------------
>
> Key: LOG4PHP-108
> URL: https://issues.apache.org/jira/browse/LOG4PHP-108
> Project: Log4php
> Issue Type: Improvement
> Components: Code
> Reporter: Florian Platzer
> Priority: Minor
> Fix For: 2.1
>
> Attachments: LoggerAppenderEcho.patch
>
> Original Estimate: 0.08h
> Remaining Estimate: 0.08h
>
> When using LoggerAppenderEcho the output will be printed in one line (in
> HTML).
> So automatically add a line break or add a new property for user's control
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
