Hi, actually I have thought on it a while and hoped somebody would comment it. Thanks Ivan for doing it finally.
> Firstly, do you think it's a good idea to have addHTMLLineBreak default to > true? This changes the current default behaviour. I mostly develop command > line apps so this was not welcome on my part. There is a second reason for defaulting to "false". Because it was "false" before. Since its nam is echoappender i thought it would be more selfexplainary with br in it, but you double my doubts and I would tend to "false" again, as you do. > Secondly, you append <br/> to end of the mesage if this option is enabled. > Wouldn't it be neater to replace all line breaks in the message with <br />? > I often log multi-line messages so from my perspective this would be the > better approach. Agreed. > Also, I think you broke one of the tests with this patch: > 1) LoggerRendererMapTest::testUsage > Failed asserting that two strings are equal. > --- Expected > +++ Actual > @@ @@ > ERROR - test1,test2,test3 > -<br /> > + That one is strange - it works fine for me. Did you update it? Cheers, Christian > > D:\Dev\log4php\src\test\php\renderers\LoggerRendererMapTest.php:82 > > > >> Add HTML line break to LoggerAppenderEcho output >> ------------------------------------------------ >> >> Key: LOG4PHP-108 >> URL: https://issues.apache.org/jira/browse/LOG4PHP-108 >> Project: Log4php >> Issue Type: Improvement >> Components: Code >> Reporter: Florian Platzer >> Priority: Minor >> Fix For: 2.1 >> >> Attachments: LoggerAppenderEcho.patch >> >> Original Estimate: 0.08h >> Remaining Estimate: 0.08h >> >> When using LoggerAppenderEcho the output will be printed in one line (in >> HTML). >> So automatically add a line break or add a new property for user's control > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
