On 30.4.2010 23:10, Christian Grobmeier wrote:
Agreed.

Then I propose to change the setting to be called "useHTMLLineBreaks" to better reflect the new behaviour. Then update the EchoAppender to convert any line breaks to <br /> if this setting is set to true.

Also, I think you broke one of the tests with this patch:
1) LoggerRendererMapTest::testUsage
Failed asserting that two strings are equal.

That one is strange - it works fine for me. Did you update it?

Strange, I just tried it out on windows and linux with code freshly checked out of the trunk. I get the error in both cases. Nevermind, we'll have to update tests anyway.

Ivan

Reply via email to