[
https://issues.apache.org/jira/browse/LOG4PHP-174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13249838#comment-13249838
]
Bruce Ingalls commented on LOG4PHP-174:
---------------------------------------
@Ivan:
Great work, thanks!
@Christoph:
Hmm. It's not a big deal, but define() smells like imperative (pre-OOP) code of
PHP 4.x compatibility.
Based on what you said, I'm thinking it /might/ make sense to declare
class Insight {
const DEBUG = true; //default
const SERVER_PATH = '/'; //define() does accept $_SERVER['REQUEST_URI']
//...
}
Unlike interfaces, users can override these default consts by extending a child
class.
I originally thought of interfaces, because I thought it might allow better
compile-time checking, as well as smelling like a Design Pattern.
PHP is not like other OOP languages.
> Firephp appender logs to Firebug console.
> -----------------------------------------
>
> Key: LOG4PHP-174
> URL: https://issues.apache.org/jira/browse/LOG4PHP-174
> Project: Log4php
> Issue Type: Improvement
> Components: Code
> Affects Versions: 2.3.0
> Environment: Mozilla Firefox, possibly Google Chrome
> Reporter: Bruce Ingalls
> Labels: features, patch
> Attachments: firephp_2012_03_16.tar.bz2, log4diff.tar.bz2
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> I followed the guidelines at
> http://logging.apache.org/log4php/contributingpatches.html
> However, Jira does not seem to have a way to upload files, such as the
> Appender I'd like to donate to this project.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
