On Tue, 2007-04-24 at 13:50 -0500, Bruce Dubbs wrote: > > In any case, I downloaded ltp-full-20070331.tgz and tried to apply your > patch and got: > > $ patch -Np1 -i ../mincore01.patch > patching file testcases/kernel/syscalls/mincore/mincore01.c > Hunk #1 FAILED at 27. > Hunk #3 FAILED at 95. > Hunk #4 FAILED at 194. > 3 out of 4 hunks FAILED -- saving rejects to file > testcases/kernel/syscalls/mincore/mincore01.c.rej
odd, it applies cleanly for me: [EMAIL PROTECTED] ~]# rm -rf ltp-full-20070331 [EMAIL PROTECTED] ~]# tar zxf ltp-full-20070331.tgz [EMAIL PROTECTED] ~]# cd ltp-full-20070331 [EMAIL PROTECTED] ltp-full-20070331]# patch -p1 < ../mincore01.patch patching file testcases/kernel/syscalls/mincore/mincore01.c [EMAIL PROTECTED] ltp-full-20070331]# The patch likely got mangled by your email client. I took the mail and saved it as a text file and tried it that way as well and it still applied cleanly. > > I applied the patch manually and the three remaining test cases passed > on my system, however I think that test 3 is still invalid as it might > provide an "unexpected pass" depending on exactly what memory is being > used at the time of execution. I saw your email on that when I went digging through the archives. I agree that in theory this case is possible but since it maps the memory itself and then runs the test the only way it could fail is if somehow it allocated another page and it just happened to end up at the same virtual address and the page we just unmapped. Have you actually seen the test fail (i.e. mincore pass unexpectedly) in this way? - Doug ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
