Sorry for the late response.
> On Friday 16 May 2008, Helge Deller wrote:
> shm05.c -> see my (untested!!!) patch below.
> Some architectures can only map at specific offsets.
> Current version "sucessfully" fails, because e.g. hppa can't map at cp+4096.
> So, it's not failing because the memory regions overlap, although that was
> intended to be tested...
>
Your patch looks good to me. It does what I'm intended but failed to do;
eliminating
explicit arch-dependent code without breaking logics.
> shm06.c now does basically the same test as shm04.c ?!?
> Doesn't make sense...
> I would revert the patch for shm06, but maybe others think different????
How about merge the scenario of shm06 into shm04, and then eliminate shm06?
Modify shm04 to attach the same segment _twice_ to the child's address space.
In this case, the first returned address should be the same as where the parent
attaches its segment to while the second returned address should be different.
>
> Other patches seem ok, although I haven't looked too deep into them yet...
>
> Helge
>
> Index: shmt05.c
> ================================================================
> ===
> RCS file: /cvsroot/ltp/ltp/testcases/kernel/mem/shmt/shmt05.c,v
> retrieving revision 1.7
> diff -u -p -r1.7 shmt05.c
> --- shmt05.c 15 May 2008 06:54:17 -0000 1.7
> +++ shmt05.c 16 May 2008 20:17:34 -0000
> @@ -53,7 +53,7 @@ extern int Tst_count; /* Test Case coun
>
> key_t key[2];
>
> -#define SIZE 16*1024
> +#define SIZE (2*SHMLBA)
>
> int rm_shm(int);
>
> @@ -93,7 +93,7 @@ int main()
> "Error: shmget: shmid1 = %d, errno = %d\n",
> shmid1, errno);
> } else {
> - cp1 = (char *)shmat(shmid1, cp + 4096, 0);
> + cp1 = (char *)shmat(shmid1, cp + (SIZE/2), 0);
> if (cp1 != (char *)-1) {
> perror("shmat");
> tst_resm(TFAIL,
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
