On Thu, 2008-05-22 at 14:11 -0700, Garrett Cooper wrote: > On May 19, 2008, at 6:49 AM, Subrata Modak wrote: > > > On Mon, 2008-05-19 at 09:43 -0400, Nate Straz wrote: > >> On May 19 02:18, Garrett Cooper wrote: > >>> The makefiles are mostly done (the top-level ones that LTP touches, > >>> i.e. not the ballista and other subproject makefiles as LTP isn't > >>> the > >>> maintainers and those should be fixed upstream), but there's some > >>> sort > >>> of misunderstanding on my part as to how define's and variable > >>> scoping, lifetime, and rule evaluation are done with GNU make(1) > >>> with > >>> include'd Makefiles, so I've punted the ball back up-court until I > >>> can > >>> get some helpful answers from them, as their documentation is > >>> slightly > >>> confusing. > >> > >> Are you converting to a non-recursive build? I made the transition > >> in one of my projects and there were a few things to keep in mind. > >> 1. All variables are global and can get overwritten in includes. > >> 2. It's best to do everything before including the next makefile. > >> 3. Target-specific variables are the best thing since sliced bread. > >> > >> I'd be willing to look at your patch and try to resolve the confusion > >> you're having. > > > > Nate, > > > > I am happy that you will be reviewing it. > > > > Garrett, > > > > I would like to have a very good document highlighting the changes and > > their benefits. > > > > Regards-- > > Subrata > > > >> > >>> So far my diff is ~190KB large. > >> > >> Is that all? ;) > >> > >> Nate > > I haven't gotten all of the changes done yet, so this effort is most > likely going to carry over into next month. I'll try and keep up with
That is not an issue at all. Giving the effort you are putting in, it would definitely take time. I am also of the opinion that you can stabilize it on your part before pushing the same to LTP. Anyways we will also have several rounds of review once that is in LTP. But it would be nice if the first push itself is in good shape. Regards-- Subrata > changes in CVS and submit everything to you folks when it's to a point > where it's mature and stable enough to be inserted into the LTP base. > I ran into a few issues / concerns with some C source files though so > I'll submit separate patches for those soon. > Thanks, > -Garrett ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
