On Tue, 2008-09-16 at 19:27 +0530, Chirag Jog wrote:
> This patch fixes two minor issues in run.sh
> 
> 1. Adds list option to the usage() command.
> 2. Remove java from "all" tests to be run.
> 
> Signed-Off-By: Chirag <[EMAIL PROTECTED]>
> 
> 
>  run.sh |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/testcases/realtime/run.sh b/testcases/realtime/run.sh
> index ce0070d..58fbd15 100755
> --- a/testcases/realtime/run.sh
> +++ b/testcases/realtime/run.sh
> @@ -39,6 +39,7 @@ function usage()
>       echo -e " stress =      all stress tests will be run "
>       echo -e " perf =        all perf tests will be run "
>       echo -e " all =         all tests will be run "
> +     echo -e " list =        all available tests will be listed  "
>       echo -e " clean =       all logs deleted, make clean performed "
>       echo -e " test_name =   only test_name subdir will be run (e.g: 
> func/pi-tests) "
>       echo -e " -p profile =  use profile instead of default "


While we're at this let's clean this up to be a bit more
uniform/standard with other usage satements.  The output currently looks
like:

Usage: run.sh [-p profile] -t test-argument [-l loop num_of_iterations]
[-t test-argument1 [-l loop ...]] ...

Where test-argument = func | stress | perf | all | list | clean |
test_name 

 and: 

 func =         all functional tests will be run 
 stress =       all stress tests will be run 
 perf =         all perf tests will be run 
 all =          all tests will be run 
 clean =        all logs deleted, make clean performed 
 test_name =    only test_name subdir will be run (e.g: func/pi-tests) 
 -p profile =   use profile instead of default 
 -h         =   help


I think the Usage line is good, but the rest could really use some
straightening up, consider:

Usage: run.sh [-p profile] -t test-arguments [-l loops]

-t test-arguments   Where test-argument can be a space separated sequence of:
                      func      all functional tests will be run 
                      stress    all stress tests will be run 
                      perf      all perf tests will be run 
                      all       all tests will be run 
                      clean     all logs deleted, make clean performed 
                      test_name only test_name subdir will be run (e.g: 
func/pi-tests) 
-l loops            run the test-argument loops times
-p profile          use profile instead of default (WHAT ARE THE POSSIBLE 
                    OPTIONS HERE?)
-h                  display this help text and exit



the above corrects the "-l loop run-num-iterations" which has two
variables after the -l instead of one.  It clarifies that test-argumentS
is a list, not only one of the options.  It clarifies that
func,stress,perf etc. are values of test-arguments, not other options.
One pending question is how does one use -p profile...

Thanks,

Darren Hart

> @@ -134,7 +135,7 @@ find_test()
>               ;;
>       all)
>               # Run all tests which have run_auto.sh
> -             TESTLIST="func stress java perf"
> +             TESTLIST="func stress perf"
>               ;;
>       list)
>               # This will only display subdirs which have run_auto.sh
> 
-- 
Darren Hart
Real-Time Linux Team Lead
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to