On Tue, 2008-09-23 at 14:40 +0530, Chirag Jog wrote:
> * Darren Hart <[EMAIL PROTECTED]> [2008-09-23 07:06:09]:
>
> > On Tue, 2008-09-23 at 11:59 +0530, Chirag Jog wrote:
> > > stress all stress tests will be run "
> > > > > + echo -e " \t\t\tperf all perf tests will be run "
> > > > > + echo -e " \t\t\t all all tests will be run"
> > > >
> > > > Appears to be an extra space here between the tabs and "all". Is that
> > > > intentional?
> > > Yes.
> > > > > + echo -e " \t\t\tlist all available tests will be
> > > > > listed "
> > > > > + echo -e " \t\t\tclean all logs deleted, make clean
> > > > > performed "
> > > > > + echo -e " \t\t\ttest_name only test_name subdir will be
> > > > > run (e.g: func/pi-tests) "
> > > > > + echo -e " \t\t\t-p profile use profile instead of default
> > > > > (see doc/AUTOMATED_RUN)"
> > > > > + echo -e " \t\t\t-h help"
> > > >
> > > > I believe -p and -h should not have the 3 \t before them... we don't
> > > > want them to line up with the test-argument options do we? In future
> > > > patches, can you porovide example output, so we don't have to parse the
> > > > echo statements?
> > > Both comments make sense.
> > > Here is the patch that fixes them.
> > >
> > > Sample output:
> > >
> > > [EMAIL PROTECTED] realtime]$ ./run.sh
> > > Usage: run.sh [-p profile] -t test-argument [-l num_of_loops]
> > >
> > > -t test-arguments Where test-argument can be a space separated sequence
> > > of:
> > >
> > > func all functional tests will be run
> > > stress all stress tests will be run
> > > perf all perf tests will be run
> > > all all tests will be run
> >
> > OK, you said the space before the a in all was intentional... can you
> > explain why?
> > All the other items line up left justified, why should "all" be indented by
> > one.
> > Now that I see this printed out (thanks for that) seems like these should
> > be sorted
> > in some way... alphabetically perhaps.
> Umm.. well there was indentation issue, which seems to be fixed now.
> Here is the output and patch:
>
> [EMAIL PROTECTED] ltp]$ ./testcases/realtime/run.sh
> Usage: run.sh [-p profile] -t test-argument [-l num_of_loops]
>
> -t test-arguments Where test-argument can be a space separated sequence
> of:
>
> func all functional tests will be run
> stress all stress tests will be run
> perf all perf tests will be run
> all all tests will be run
> list all available tests will be listed
> clean all logs deleted, make clean performed
> test_name only test_name subdir will be run (e.g:
> func/pi-tests)
>
> -p profile Use profile instead of default (see doc/AUTOMATED_RUN)
>
> -h help
>
>
> Signed-Off-By: Chirag <[EMAIL PROTECTED]>
I'd still like to see some sort of order to the output, but this is a
clear incremental improvement that doesn't add any problems of its own,
so:
Acked-by: Darren Hart <[EMAIL PROTECTED]>
>
> Index: ltp/testcases/realtime/run.sh
> ===================================================================
> --- ltp.orig/testcases/realtime/run.sh
> +++ ltp/testcases/realtime/run.sh
> @@ -33,16 +33,16 @@
> function usage()
> {
> echo -e "\nUsage: run.sh [-p profile] -t test-argument [-l
> num_of_loops]"
> - echo -e "\n-t test-arguments Where test-argument can be a space
> separated sequence of: "
> - echo -e " \t\t\tfunc all functional tests will be run "
> + echo -e "\n-t test-arguments\tWhere test-argument can be a space
> separated sequence of: "
> + echo -e " \n\t\t\tfunc all functional tests will be run "
> echo -e " \t\t\tstress all stress tests will be run "
> echo -e " \t\t\tperf all perf tests will be run "
> - echo -e " \t\t\t all all tests will be run"
> + echo -e " \t\t\tall all tests will be run"
> echo -e " \t\t\tlist all available tests will be listed "
> echo -e " \t\t\tclean all logs deleted, make clean performed "
> echo -e " \t\t\ttest_name only test_name subdir will be run (e.g:
> func/pi-tests) "
> - echo -e " \t\t\t-p profile use profile instead of default (see
> doc/AUTOMATED_RUN)"
> - echo -e " \t\t\t-h help"
> + echo -e "\n-p profile\t\tUse profile instead of default (see
> doc/AUTOMATED_RUN)"
> + echo -e " \n-h\t\t\thelp"
> echo -e "\n"
> exit 1;
> }
>
--
Darren Hart
Real-Time Linux Team Lead
IBM Linux Technology Center
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
