* Darren Hart <[EMAIL PROTECTED]> [2008-09-22 09:49:31]:
> On Wed, 2008-09-17 at 13:41 +0530, Chirag Jog wrote:
> > * Darren Hart <[EMAIL PROTECTED]> [2008-09-16 15:27:10]:
> >
> > This patch fixes a few minor issues in run.sh
> >
> > 1. Adds list option to the usage() command.
> > 2. Remove java from "all" tests to be run.
> > 3. It fix the output of usage (./run.sh or ./run.sh -h)
> >
> > Tested: Running "./run.sh -t func", "./run.sh -t all" , "./run.sh",
> > "./run.sh -h"
> >
> >
> > Signed-Off-By: Chirag <[EMAIL PROTECTED]>
> >
> >
> >
> > diff --git a/testcases/realtime/config.mk b/testcases/realtime/config.mk
> > index 083db58..19ccddc 100644
> > --- a/testcases/realtime/config.mk
> > +++ b/testcases/realtime/config.mk
> > @@ -23,4 +23,3 @@ LDLIBS += $(srcdir)/lib/libjvmsim.o \
> > $(srcdir)/lib/libstats.o \
> > -lpthread -lrt -lm
> >
> > -CFLAGS += -m64
> > diff --git a/testcases/realtime/run.sh b/testcases/realtime/run.sh
> > index ce0070d..f1e03ad 100755
> > --- a/testcases/realtime/run.sh
> > +++ b/testcases/realtime/run.sh
> > @@ -32,17 +32,17 @@
> >
> > function usage()
> > {
> > - echo -e "\nUsage: run.sh [-p profile] -t test-argument [-l loop
> > num_of_iterations] [-t test-argument1 [-l loop ...]] ..."
> > - echo -e "\nWhere test-argument = func | stress | perf | all | list |
> > clean | test_name "
> > - echo -e "\n and: \n"
> > - echo -e " func = all functional tests will be run "
> > - echo -e " stress = all stress tests will be run "
> > - echo -e " perf = all perf tests will be run "
> > - echo -e " all = all tests will be run "
> > - echo -e " clean = all logs deleted, make clean performed "
> > - echo -e " test_name = only test_name subdir will be run (e.g:
> > func/pi-tests) "
> > - echo -e " -p profile = use profile instead of default "
> > - echo -e " -h = help"
> > + echo -e "\nUsage: run.sh [-p profile] -t test-argument [-l
> > num_of_loops]"
> > + echo -e "\n-t test-arguments Where test-argument can be a space
> > separated sequence of: "
> > + echo -e " \t\t\tfunc all functional tests will be run "
> > + echo -e " \t\t\tstress all stress tests will be run "
> > + echo -e " \t\t\tperf all perf tests will be run "
> > + echo -e " \t\t\t all all tests will be run"
>
> Appears to be an extra space here between the tabs and "all". Is that
> intentional?
Yes.
> > + echo -e " \t\t\tlist all available tests will be listed "
> > + echo -e " \t\t\tclean all logs deleted, make clean performed "
> > + echo -e " \t\t\ttest_name only test_name subdir will be run (e.g:
> > func/pi-tests) "
> > + echo -e " \t\t\t-p profile use profile instead of default (see
> > doc/AUTOMATED_RUN)"
> > + echo -e " \t\t\t-h help"
>
> I believe -p and -h should not have the 3 \t before them... we don't
> want them to line up with the test-argument options do we? In future
> patches, can you porovide example output, so we don't have to parse the
> echo statements?
Both comments make sense.
Here is the patch that fixes them.
Sample output:
[EMAIL PROTECTED] realtime]$ ./run.sh
Usage: run.sh [-p profile] -t test-argument [-l num_of_loops]
-t test-arguments Where test-argument can be a space separated sequence
of:
func all functional tests will be run
stress all stress tests will be run
perf all perf tests will be run
all all tests will be run
list all available tests will be listed
clean all logs deleted, make clean performed
test_name only test_name subdir will be run (e.g:
func/pi-tests)
-p profile Use profile instead of default (see doc/AUTOMATED_RUN)
-h help
Signed-Off-By: Chirag <[EMAIL PROTECTED]>
Index: ltp/testcases/realtime/run.sh
===================================================================
--- ltp.orig/testcases/realtime/run.sh
+++ ltp/testcases/realtime/run.sh
@@ -33,16 +33,16 @@
function usage()
{
echo -e "\nUsage: run.sh [-p profile] -t test-argument [-l
num_of_loops]"
- echo -e "\n-t test-arguments Where test-argument can be a space
separated sequence of: "
- echo -e " \t\t\tfunc all functional tests will be run "
+ echo -e "\n-t test-arguments\tWhere test-argument can be a space
separated sequence of: "
+ echo -e " \n\t\t\tfunc all functional tests will be run "
echo -e " \t\t\tstress all stress tests will be run "
echo -e " \t\t\tperf all perf tests will be run "
echo -e " \t\t\t all all tests will be run"
echo -e " \t\t\tlist all available tests will be listed "
echo -e " \t\t\tclean all logs deleted, make clean performed "
echo -e " \t\t\ttest_name only test_name subdir will be run (e.g:
func/pi-tests) "
- echo -e " \t\t\t-p profile use profile instead of default (see
doc/AUTOMATED_RUN)"
- echo -e " \t\t\t-h help"
+ echo -e "\n-p profile\t\tUse profile instead of default (see
doc/AUTOMATED_RUN)"
+ echo -e " \n-h\t\t\thelp"
echo -e "\n"
exit 1;
}
--
-Thanks,Chirag
-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list
