Quoting Kamalesh Babulal ([email protected]):

> Sorry send the wrong patch

Aaah.

> > > 
> > > 1. SELinux on (attr/* read successfuly)
> > > 2. AppArmor on (???)
> > > 3. SELinux off and AppArmor off (attr/* read with -EINVAL)
> > 4. TOMOYO on
> > 5. Smack on
> > ...
> > 
> > > As the result, the above checking code will need to be present in both
> > > proc01 and a new test.
> > 
> > Then please stick to the simple suggestion from Stephen, keeping
> > any selinux- (or any other lsm-)specific code out of proc01.c.
> > 
> > Which may be what you're suggesting  :)
> > 
> > -serge
> 
> We can just add the files related to LSM, to known failure list. We already 
> check
> for their return value, if not EINVAL report test failure or else skip.
> Added the nfsd files to the list. 
> 
> ---
>  testcases/kernel/fs/proc/proc01.c |    7 +++++++
>  1 file changed, 7 insertions(+)
> 
> Index: b/testcases/kernel/fs/proc/proc01.c
> ===================================================================
> --- a/testcases/kernel/fs/proc/proc01.c
> +++ b/testcases/kernel/fs/proc/proc01.c
> @@ -88,6 +88,13 @@ const Mapping known_issues[] =
>      {"read", "/proc/xen/privcmd", EINVAL},
>      {"read", "/proc/self/mem", EIO},
>      {"read", "/proc/self/task/[0-9]*/mem", EIO},
> +     {"read", "/proc/self/attr/*", EINVAL},
> +     {"read", "/proc/self/task/[0-9]*/attr/*", EINVAL},
> +     {"read", "/proc/fs/nfsd/unlock_filesystem", EINVAL},
> +     {"read", "/proc/fs/nfsd/unlock_ip", EINVAL},
> +     {"read", "/proc/fs/nfsd/filehandle", EINVAL},
> +     {"read", "/proc/fs/nfsd/.getfs", EINVAL},
> +     {"read", "/proc/fs/nfsd/.getfd", EINVAL},

Can't speak to the nfs parts, but putting the attr/* files
there looks just right.

thanks,
-serge

>      {"", "", 0}
>    };
> 
> -- 
> Thanks & Regards,
> Kamalesh Babulal,
> Linux Technology Center,
> IBM, ISTL.

------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to