Hi, >>>> >>>> >>> 1) Being LTP, it should follow Linux Coding style, >>> >>> >> What about to run Lindent script to code? >> I don't like it because sometimes do weird coding style >> but I think will be better to do it because from some my tests I see >> that almost every file has coding style violation. >> Then fix coding style violations in single file. >> Is it OK for you? >> > > No. That would be hard to review for anybody. You can send a single file > patch for one particular subsystem test(s), say like: > > 1) A single file patch for fixing Coding styles in SYSCALLS tests, > 2) A separate file patch for fixing Coding styles in FS tests, > 3) A separate file patch for fixing Coding styles in Memory tests, > etc, > > You can divide your time for them separately. May be SYSCALLS in March, > FS in April like that. Gives you and us the time to stabilize. However > if you are fast, send them immediately ;-) > BTW: you have release every month, right? It is end of February and it will be better to post changes next month.
Thanks, Michal > Regards-- > Subrata > > >> Any comment is appreciated. >> >> Thanks, >> Michal >> >>> 2) Should also follow the guidelines for writing tests in C and Shell as >>> mentioned in: >>> http://ltp.sourceforge.net/documentation/how-to/ltp.php, >>> >>> There are lots of tests in LTP which has to be moved to follow that >>> standard(s) and use LTP libraries instead of printf(), etc. However, >>> till your program reports PASS/FAIL properly, it can be written in any >>> language as such, and may not strictly use the LTP APIs (for the sake of >>> getting new tests). However, Authors/Interested persons can take up to >>> do the cleanups necessary as per their schedule. >>> >>> Regards-- >>> Subrata >>> >>> >>> >>>> Thanks, >>>> Michal >>>> >>>> >>>> >>> >>> >> > > -- Michal Simek, Ing. (M.Eng) PetaLogix - Linux Solutions for a Reconfigurable World w: www.petalogix.com p: +61-7-30090663,+42-0-721842854 f: +61-7-30090663 ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
