On Fri, 2009-02-27 at 07:53 +0100, Michal Simek wrote: > Hi, > >>> 1) Being LTP, it should follow Linux Coding style, > >>> > >>> > >> What about to run Lindent script to code? > >> I don't like it because sometimes do weird coding style > >> but I think will be better to do it because from some my tests I see > >> that almost every file has coding style violation. > >> Then fix coding style violations in single file. > >> Is it OK for you? > >> > > > > No. That would be hard to review for anybody. You can send a single file > > patch for one particular subsystem test(s), say like: > > > Yes, I will be harder to review it but on the other hand is especially > for me to read the code. > > 1) A single file patch for fixing Coding styles in SYSCALLS tests, > > 2) A separate file patch for fixing Coding styles in FS tests, > > 3) A separate file patch for fixing Coding styles in Memory tests, > > etc, > > > > You can divide your time for them separately. May be SYSCALLS in March, > > FS in April like that. Gives you and us the time to stabilize. However > > if you are fast, send them immediately ;-) > > > Yes I mean that. It is no so hard to run Lindent only on separate > folders and commit them. > I haven't seen a reason why I should run this one line command in March > and again in April and again ... > It is easier for me to run it in one day. :-) I'll look at it. >
I just wanted them to be in separate patches for better review. Regards-- Subrata > Thanks, > Michal > > > Regards-- > > Subrata > > > > > ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
