On Fri, 2009-02-27 at 08:46 +0100, Michal Simek wrote: > Hi > >> Hi, > >> > >>>>> 1) Being LTP, it should follow Linux Coding style, > >>>>> > >>>>> > >>>>> > >>>> What about to run Lindent script to code? > >>>> I don't like it because sometimes do weird coding style > >>>> but I think will be better to do it because from some my tests I see > >>>> that almost every file has coding style violation. > >>>> Then fix coding style violations in single file. > >>>> Is it OK for you? > >>>> > >>>> > >>> No. That would be hard to review for anybody. You can send a single file > >>> patch for one particular subsystem test(s), say like: > >>> > >>> > >> Yes, I will be harder to review it but on the other hand is especially > >> for me to read the code. > >> > >>> 1) A single file patch for fixing Coding styles in SYSCALLS tests, > >>> 2) A separate file patch for fixing Coding styles in FS tests, > >>> 3) A separate file patch for fixing Coding styles in Memory tests, > >>> etc, > >>> > >>> You can divide your time for them separately. May be SYSCALLS in March, > >>> FS in April like that. Gives you and us the time to stabilize. However > >>> if you are fast, send them immediately ;-) > >>> > >>> > >> Yes I mean that. It is no so hard to run Lindent only on separate > >> folders and commit them. > >> I haven't seen a reason why I should run this one line command in March > >> and again in April and again ... > >> It is easier for me to run it in one day. :-) I'll look at it.
Are you planning to work on this still ? Regards-- Subrata > >> > >> > > > > I just wanted them to be in separate patches for better review. > > > Yes, of course. > > M > > Regards-- > > Subrata > > > > > >> Thanks, > >> Michal > >> > >> > >>> Regards-- > >>> Subrata > >>> > >>> > >>> > > > > > > ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
