On Sunday 01 March 2009 22:00:14 Garrett Cooper wrote: > On Mar 1, 2009, at 6:43 PM, Mike Frysinger wrote: > > On Sunday 01 March 2009 19:54:20 Garrett Cooper wrote: > >> On Mar 1, 2009, at 1:51 PM, Mike Frysinger wrote: > >>> On Sunday 01 March 2009 16:24:28 Németh Márton wrote: > >>>> +#if 0 > >>> > >>> what's with all this "#if 0" junk ? delete that cruft please. > >> > >> Apart from that, does this cause regressions with earlier kernels? I > >> don't see version specific API checks... > > > > i dont think we want to get into the business of supporting a wide > > range of > > kernels. every other project that has tried has ended up with an > > ifdef mess. > > Then why are we worried about 2.4 regressions like we have been > in the past? And what happens to all of the folks with kernel versions > prior to this change? This test will break.
i'm not worried about 2.4 regressions with *kernel* modules. the API has changed significantly between 2.4 and 2.6. there really isnt a way to abstract those away. maybe Subrata has a different opinion. either way, we need to spell this out explicitly in the LTP sources. > This can turn into less of an ifdef mess by properly making these > calls into either macros, or version specific translation function > calls in C. every project ive seen has tried this and failed. it still turns into a mess as it isnt simply function calls changing names. arguments changes (type and the number of arguments). interfaces change (or go away completely). > Don't you love all of the POLA changes in Penguin-land :(? userspace ABI is one thing. in-kernel API is completely different ball game. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
