Mike Frysinger wrote:
> On Sunday 01 March 2009 16:24:28 Németh Márton wrote:
>> +#if 0
>
> what's with all this "#if 0" junk ? delete that cruft please.
These should be really
#if LINUX_VERSION_CODE <= KERNEL_VERSION(2, x, y)
.../* old code here */
#else
.../* new code here */
#endif
where x and y are the latest kernel version where the "old code" works, and
after that version the "new code".
I couldn't find out the x and y, yet, so I just used "#if 0" instead.
I'll send a new patch where I remove this kind of "#if 0", so Subrata can
decide which version he wants to apply.
However, there are other types of #if 0: these are old test cases which I
could not easily compile. I have not spend much time finding out what the
test case would like to do and why. If there was a compiler error which I
could not solve easily, I just disabled the test case for now.
Regards,
Márton Németh
------------------------------------------------------------------------------
Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA
-OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise
-Strategies to boost innovation and cut costs with open source participation
-Receive a $600 discount off the registration fee with the source code: SFAD
http://p.sf.net/sfu/XcvMzF8H
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list