On Thursday 02 July 2009 05:05:32 Matt Helsley wrote: > As best I can tell these tests do not use true sh syntax -- they use bash > syntax. Rather than bother hunting down all the bash-isms just convert > them to use bash as their interpretter.
the changelog doesnt seem to jive with the commit. if you were merely changing the shebang, why did you also fix the bashisms like s/==/-eq/ ? at any rate, someone (i dont recall who) posted fixes to these files recently to de-bashify them. there was some feedback though, so perhaps you should address those minor issues and submit an updated patch. in general, converting sh to bash is a bad idea as it can cause issues for us embedded peeps. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
