On Thu, Jul 2, 2009 at 8:42 PM, Mike Frysinger<[email protected]> wrote: > On Thursday 02 July 2009 23:27:52 Garrett Cooper wrote: >> On Thu, Jul 2, 2009 at 7:45 PM, Mike Frysinger wrote: >> > how about we aim for avoiding the include completely regardless of >> > target. really config.mk is setting up the environment and recursive >> > makes should be inheriting those. so if our toplevel .mk exported >> > something like: LTP_CONFIG_INCLUDED = yes >> > >> > then all the fragments in the sub-makefiles should look like: >> > ifneq ($(LTP_CONFIG_INCLUDED),yes) >> > include $(topdir)/config.mk >> > endif >> > >> > then you could have the clean target lie by doing: >> > $(MAKE) -C testcases LTP_CONFIG_INCLUDED=yes clean >> > >> > which would address all of your concerns ? >> >> Yes. That's sort of the concern that I was going for with my previous >> spin, but then it turned into a gob of Makefile.inc files that were >> being added unnecessarily to the SCM. Considering that the include >> file is only needed for files that include config.mk (which are a >> small handful -- 10 to be exact), I figured that adding the necessary >> logic to the top would be wise. > > today it is 10, but ideally this is the format we'll be moving to > -mike
Yes. I'm respinning this diff today as one file, and I'll be submitting other patches today sometime before 8pm PST as well, which will mark the initial evolution of the Make system provided the feedback that you gave me. Thanks, -Garrett ------------------------------------------------------------------------------ _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
