On Wednesday 09 September 2009 08:31:10 Cyril Hrubis wrote: > > the _GNU_SOURCE change shouldnt be in there (existing style is correct) > > I don't like adding spaces between # and keyword but changed back as you > wish.
lack of indentation in nested #if quickly makes for unreadable and unmaintainable code. #ifdef FOO #some more ifdefs #ifdef MOO #some more ifdesf #else #some more #endif #endif whereas the whitespace makes the nested logic trivial to track > > the fall back error should be TCONF, and it shouldnt say "epoll library" > > as there is no such thing. a better message might be "no epoll support > > found". > > Okay. > > Fixed patch attached. looks good to me, thanks -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
