On Wednesday 09 September 2009 09:07:00 Cyril Hrubis wrote:
> > > > the _GNU_SOURCE change shouldnt be in there (existing style is
> > > > correct)
> > >
> > > I don't like adding spaces between # and keyword but changed back as
> > > you wish.
> >
> > lack of indentation in nested #if quickly makes for unreadable and
> > unmaintainable code.
> > #ifdef FOO
> > #some more ifdefs
> > #ifdef MOO
> > #some more ifdesf
> > #else
> > #some more
> > #endif
> > #endif
> >
> > whereas the whitespace makes the nested logic trivial to track
> 
> Agree with that (and I would be nice to fix all unreadable code in ltp).
>  But as I rarely use anything else that gcc, puting whitespaces before # is
>  not problem for me and this style IMHO looks better. I know that works
>  only for my personal projects, but have you seen compiler that is used
>  these days and has problems with that?

earlier C standards reject leading whitespace.  no idea when it changed.  plus 
the common practice appears to largely be space after the #, not before.
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

Reply via email to