On Wednesday 09 September 2009 17:28:46 Garrett Cooper wrote: > On Wed, Sep 9, 2009 at 10:55 AM, Subrata Modak wrote: > > On Wed, 2009-09-09 at 14:31 +0200, Cyril Hrubis wrote: > >> > the _GNU_SOURCE change shouldnt be in there (existing style is > >> > correct) > >> > >> I don't like adding spaces between # and keyword but changed back as you > >> wish. > >> > >> > the fall back error should be TCONF, and it shouldnt say "epoll > >> > library" as there is no such thing. a better message might be "no > >> > epoll support found". > >> > >> Okay. > >> > >> Fixed patch attached. > >> > >> Signed-off-by: Cyril Hrubis [email protected] > > Sorry for not injecting sooner: > > CPPFLAGS += -D_GNU_SOURCE > > would be better in the Makefile -- otherwise it makes for > inconsistently compiled objects.
i actually prefer to have _XXX_SOURCE defines in the file itself so that it works if people compile the program by hand, and so that you dont end up forcing the same _XXX_SOURCE on multiple programs in the same dir when it's only wanted on one or two. while it can be done on a per-program basis in the Makefile, people dont generally do that ... they stick it in the common CFLAGS and forget. -mike
signature.asc
Description: This is a digitally signed message part.
------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
