> -----Original Message----- > From: Garrett Cooper [mailto:[email protected]] > Sent: Saturday, November 20, 2010 2:33 AM > To: Cyril Hrubis > Cc: Bian Naimeng; [email protected]; Mitani > Subject: Re: [LTP] [POSIX][PATCH]Instead sem_wait by fcntl for > sigaction test. > > On Fri, Nov 19, 2010 at 4:21 AM, Cyril Hrubis <[email protected]> wrote: > > Hi! > >> Some days before, mitani-san reported some sigaction test failed > at linux, > >> > http://sourceforge.net/mailarchive/message.php?msg_id=000001cb798d > %241aaa0210%244ffe0630%24%40co.jp > >> > >> As Garrett said, add Linux-isms is not advisably. So i want try to > fix it by another method. > >> > >> I have seen the assertions.xml, these tests want to test sigaction > with SA_RESTART > >> not sem_wait(it looks like there's a bug at older linux kernel), > so i suggest to > >> instead sem_wait by fcntl. > >> > >> What about this one? If you agree with me, i will post other patchs. > > > > As far as I understand this, you are trying to avoid a fact, that > older > > kernels are not comforming to the POSIX specification. This is a case > > where the test is failing for a good reason, all we could do here > is > > print message like: > > > > "this test is known to fail on linux kernel < 2.6.22" > > > > Before the test reports failure. > > Well... I would actually record these items in a file somewhere. Once > upon a time the ltp-results@ list was a good source for this data, but > I don't know how useful this data is anymore or how much/well this > data is reported and subsequently mined (I'm not on the list for > instance)... > > > On the other end I do not object to adding test for file locks with > > SA_RESTART. But you should not remove the sem_lock() test (as it's > not > > broken). > > Agreed. > > Thanks, > -Garrett
If "this test is known to fail on linux kernel < 2.6.22" message is indicated, I think it is desirable. And I hope that the "sigaction" tests don't finish with "FAILED", but finish with "UNTESTED" or "UNRESOLVED". Regards-- -Tomonori Mitani ------------------------------------------------------------------------------ Increase Visibility of Your 3D Game App & Earn a Chance To Win $500! Tap into the largest installed PC base & get more eyes on your game by optimizing for Intel(R) Graphics Technology. Get started today with the Intel(R) Software Partner Program. Five $500 cash prizes are up for grabs. http://p.sf.net/sfu/intelisp-dev2dev _______________________________________________ Ltp-list mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/ltp-list
