Hi Digy, Ha, ha... I totally forgot about a Remove. I agree, that's pushing it. :) I'll add one.
A fully implemented IDictionary contract would be really nice, and I'll support such effort. But at this point, I really, really want to get an official, final 2.3.2 tag and use it. A full implementation will require additional testing, review, etc - i.e. time. So, I'll suggest we enter a Jira enhancement "Complete WeakHashTable implementation" for 2.4.0. and have the nunit tests to go with it. tjk :) On Thu, Jan 15, 2009 at 3:08 PM, Digy (JIRA) <j...@apache.org> wrote: > > [ > https://issues.apache.org/jira/browse/LUCENENET-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12664264#action_12664264 > ] > > Digy commented on LUCENENET-106: > -------------------------------- > >>>terating and counting elements in such storage brings additional problems - >>>like handling cases when the count does not match the number of iterated >>>elements, objects not being there when at some point they were, etc > > That problems can be overcome with storing elements in a temp-table(making a > strong reference to them) and returning it, as I tried in V2. But I see the > discussion of having "full fledged" or minimal WeakHashTable as a endless > story. Therefore I am OK with the TJ's solution. I tested it and everything > seems to be alright. > > PS: Not having a "Remove" method is a very minimalist approach. > > > DIGY > >> Lucene.NET (Revision: 603121) is leaking memory >> ----------------------------------------------- >> >> Key: LUCENENET-106 >> URL: https://issues.apache.org/jira/browse/LUCENENET-106 >> Project: Lucene.Net >> Issue Type: Bug >> Environment: .NET 2.0 >> Reporter: Anton K. >> Assignee: Digy >> Priority: Critical >> Attachments: DIGY-FieldCacheImpl.patch, Digy.rar, >> luceneSrc_memUsage.patch, Paches for v2.3.1.rar, WeakHashTable v2.patch, >> WeakHashTable v2.patch, WeakHashTable+FieldCacheImpl.rar, >> WeakHashTable_tj.zip, WeakReferences.rar >> >> >> readerCache Hashtable field (see FieldCacheImpl.cs) never releases some hash >> items that have closed IndexReader object as a key. So a lot of Term >> instances are never released. >> Java version of Lucene uses WeakHashMap and therefore doesn't have this >> problem. >> This bug can be reproduced only when Sort functionality used during search. >> See following link for additional information. >> http://www.gossamer-threads.com/lists/lucene/java-user/55681 >> Steps to reproduce: >> 1)Create index >> 2) Modify index by IndexWiter; Close IndexWriter >> 3) Use IndexSearcher for searching with Sort; Close InexSearcher >> 4) Go to step 2 >> You'll get OutOfMemoryException after some time of running this algorithm. > > -- > This message is automatically generated by JIRA. > - > You can reply to this email to add a comment to the issue online. > >
