Hi Serge,
> This needs to just be
>
> oldlen = newlen;
Oh, yes, that's right, it's the buffer length and not the string length.
Sorry, I did that late at night and some things got mixed up in my head.
>> @@ -1128,7 +1152,7 @@ void lxc_cgroup_destroy_desc(struct cgroup_desc
>> *cgroups)
>> int lxc_cgroup_attach(pid_t pid, const char *name, const char *lxcpath)
>> {
>> FILE *f;
>> - char *line = NULL, ret = -1;
>> + char *line = NULL, ret = 0;
>> size_t len = 0;
>> int first = 1;
>> char *dirpath;
>
> Note you are returning 0 here if /proc/groups couldn't be opened. Was
> that your intent? Should I just add a 'return -1' on that failure?
Oh, sorry, yes, you're right. Again, late at night. ;)
-- Christian
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Lxc-devel mailing list
Lxc-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/lxc-devel
